Node functions get t as float, x as readonly #628
Conversation
|
LGTM 🍰 |
|
Me too; merging! |
Node functions now receive `t` as a float (as opposed to a zero-dimensional array), and `x` as a readonly view onto the simulator data. This addresses #626.
|
Amended in a changelog entry. My thought process (which I want to make sure matches other people's) is that every PR should have a corresponding changelog entry; there's a bit of worry that we're duplicating info that is in the commit messages, but changelog entries should always be one line, with a pointer to the issue / PR that introduced the fix / feature. That way the bulk of the info (if people care) is in the commit message / issue / PR discussion, while the changelog makes sure that we don't have to scramble to say what's new in each version. Any objections to that? |
|
No, that sounds like a good idea. I'll try to remember to put those in. I think it's also not necessarily a bad thing to do them at the end of a PR (when it's clear what the actual changes are) as opposed to the beginning, but the best is probably to put something in at the beginning and then edit it as need be. |
|
Yeah, actually this is perhaps more appropriately a job for the merger rather than the author (though the author should feel free to add one if they choose). But just wanted to make sure tracking these is OK! |
|
Yeah, it's nice to have it all in one place. An additional benefit is that a |
Node functions now receive
tas a float (as opposed to azero-dimensional array), and
xas a readonly view onto thesimulator data. This addresses #626.