Fix SP creation to use correct # of attempts #817
Conversation
| @@ -92,7 +92,7 @@ def create_pointer(self, attempts=100, unitary=False): | |||
| count = 0 | |||
| p = pointer.SemanticPointer(self.dimensions, rng=self.rng) | |||
| if self.vectors.shape[0] > 0: | |||
| while count < 100: | |||
| while count < attempts: | |||
There was a problem hiding this comment.
Damnit! That bug has been in the code for years. Good find!
There was a problem hiding this comment.
Did anyone ever specify a different number of attempts? 😛
There was a problem hiding this comment.
Not that I know of.
Oh, and while I'm thinking about it, every now and then I realize that this attempt thing really should keep track of the best one that it finds, and use that if it can't find one smaller than max_similarity. In other words, it could at least do the best it can, rather than just sticking with the last one if it fails.....
There was a problem hiding this comment.
Ok, I've updated this pull request with a new commit that includes Terry's suggestion. I checked that the best pointer is saved properly using a few print statements, but feel free to pass along any suggestions for improvements.
|
I suppose if you're trying keep the dimensionality of your SP's low for computational efficiency but want to use a relatively large number of them, it might be useful to increase the number of attempts. +1 for tracking the using the best candidate SP if the max_similarity constraint is not satisfied though. |
|
I fixed up the |
|
Agreed, looks good! Should this get a changelog entry? |
|
Hmm, I guess it did fix a bug and change behaviour a little. Probably best to get in the habit of adding them, even for little things like this. |
|
Okay, added the changelog entry. Travis has gone INSANE! |
I believe that's because we're depending on |
|
@tbekolay, do you want to merge this one, since I re-wrote a good chunk of it? |
|
Sounds good, will look at this now. |
Also, if a pointer cannot be found within the tolerance in the specified number of attempts, return the best candidate SP.
tbekolay
force-pushed
the
vocab-fixes
branch
from
4ce81bb
to
608077c
Compare
Fixes a minor bug in the create_pointer method of the Vocabulary class that results in 100 attempts being made to generate an acceptable semantic pointer regardless of the number of attempts specified by the user.