Change cache logging level to debug #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some tests need adjustment. Or maybe it is best to keep the debug argument for backwards compatibility? |
|
I think very few people are using this (if any), so I'm not worried about backwards compatibility. Fixed the tests. |
|
This should probably have a changelog entry. |
|
Good point! |
Large models can have lots of cache interaction, and logging at 'info' level can flood the log. Also made the `log` utility function able to set arbitrary levels.
tbekolay
force-pushed
the
logging-fixes
branch
from
1d833aa
to
c09aec7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large models can have lots of cache interaction, and logging at
'info' level can flood the log. Also made the
logutility functionable to set arbitrary levels.