-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate Coverage #113
Calculate Coverage #113
Conversation
@erikzhang We need to configure the environment variable for codecov as we did in the past in other neo projects. Could you do it please? |
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
=========================================
Coverage ? 44.06%
=========================================
Files ? 12
Lines ? 3499
Branches ? 0
=========================================
Hits ? 1542
Misses ? 1957
Partials ? 0 Continue to review full report at Codecov.
|
Done, the problem is that So the coverage is only for |
We should remove OSX here too? or not because is not a library? @erikzhang |
Just remove it. |
|
I think there is no need to upgrade the target frameworks of these projects. |
Is not better to have all the projects unified? |
When we are going to upgrade the target framework, either because the new framework fixes a serious bug or because we want to use the new features in the new framework. Otherwise, the lower the version of the framework, the better, because there will be better compatibility. |
So do you think that we should only upgrade the unit test? or none of them? |
None of them. |
Then leave it only for coverage |
Require neo-project/neo#1178