Calculate Coverage

[shargon]

Require neo-project/neo#1178

[shargon]

@erikzhang We need to configure the environment variable for codecov as we did in the past in other neo projects. Could you do it please?

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@502c0ab). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #113   +/-   ##
=========================================
  Coverage          ?   44.06%           
=========================================
  Files             ?       12           
  Lines             ?     3499           
  Branches          ?        0           
=========================================
  Hits              ?     1542           
  Misses            ?     1957           
  Partials          ?        0

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 502c0ab...8f1e91e. Read the comment docs.

[shargon]

Done, the problem is that SmartContract.Framework could not be instrumented by the coverage engine because it's executed on the VM and the test will fail. Although i fix in the compiler the instrumentation issues, it never be executed because is executed inside the neo VM.

So the coverage is only for Neo.Compiler.MSIL

[shargon]

We should remove OSX here too? or not because is not a library? @erikzhang

[erikzhang]

Just remove it.

[shargon]

Ok, then it's done

[erikzhang]

I think there is no need to upgrade the target frameworks of these projects.

[shargon]

Is not better to have all the projects unified?

[erikzhang]

When we are going to upgrade the target framework, either because the new framework fixes a serious bug or because we want to use the new features in the new framework. Otherwise, the lower the version of the framework, the better, because there will be better compatibility.

[shargon]

So do you think that we should only upgrade the unit test? or none of them?

[erikzhang]

None of them.

[shargon]

Then leave it only for coverage