Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AssemblyName #607

Merged
merged 5 commits into from
May 10, 2021
Merged

Use AssemblyName #607

merged 5 commits into from
May 10, 2021

Conversation

erikzhang
Copy link
Member

Close #602

shargon
shargon previously approved these changes May 6, 2021
superboyiii
superboyiii previously approved these changes May 6, 2021
Copy link
Member

@superboyiii superboyiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well for me. Assembly > csproj > class name.

@devhawk
Copy link
Contributor

devhawk commented May 6, 2021

The issue that #602 raises is the need for build systems to know what the name of a tool's output will without having to know the contents of the inputs.

I'm fine with nccs to using the contract name as the base name of the generated .nef/.manifest.json/.nefdbgnfo files by default. #602 is proposing the addition of a mechanism so the build system can override that default.

Adding an --assembly-name (or other similarly named) command line option enables the build system to override the default base name, regardless if nccs is provided a single .cs file, a .csproj file or a directory of .cs files.

Parsing the AssemblyName property out of the .csproj file is more complex and doesn't provide a mechanism to control output base name for the single .cs file or directory of .cs files solution.

@erikzhang erikzhang dismissed stale reviews from superboyiii and shargon via 34f0839 May 8, 2021 07:25
@erikzhang erikzhang requested a review from devhawk May 8, 2021 07:26
@erikzhang erikzhang merged commit 71eb2d6 into master May 10, 2021
@erikzhang erikzhang deleted the AssemblyName branch May 10, 2021 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nccs needs option to specify the .nef filename
4 participants