-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Compiler Fix + Framework Add] add oracle interface and fix issue #959
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
using Neo.SmartContract.Framework.Native; | ||
|
||
namespace Neo.SmartContract.Framework.Interfaces; | ||
|
||
/// <summary> | ||
/// Interface of oracle callback method | ||
/// </summary> | ||
public interface IOracle | ||
{ | ||
/// <summary> | ||
/// This method is called after the Oracle receives response from requested URL | ||
/// </summary> | ||
/// <param name="requestedUrl">The url of the data source</param> | ||
/// <param name="userData">Extra oracle request data specified by user</param> | ||
/// <param name="oracleResponse">Oracle response code <see cref="OracleResponseCode"/> from data source</param> | ||
/// <param name="jsonString">The oracle response data in format of json string</param> | ||
/// | ||
/// <example> | ||
/// public static void OnOracleResponse(string url, object userData, OracleResponseCode code, string result) | ||
/// { | ||
/// if (Runtime.CallingScriptHash != Oracle.Hash) throw new Exception("Unauthorized!"); | ||
/// Storage.Put(Storage.CurrentContext, PreData, result); | ||
/// } | ||
/// </example> | ||
public void OnOracleResponse( | ||
string requestedUrl, | ||
object userData, | ||
OracleResponseCode oracleResponse, | ||
string jsonString); | ||
} |
18 changes: 18 additions & 0 deletions
18
tests/Neo.SmartContract.Framework.TestContracts/Contract_IOracle.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
using Neo.SmartContract.Framework.Interfaces; | ||
using Neo.SmartContract.Framework.Native; | ||
using Neo.SmartContract.Framework.Services; | ||
|
||
namespace Neo.SmartContract.Framework.UnitTests.TestClasses | ||
{ | ||
public class Contract_IOracle : SmartContract, IOracle | ||
{ | ||
private const string PreData = "PreData"; | ||
|
||
public void OnOracleResponse(string url, object userData, OracleResponseCode code, string result) | ||
{ | ||
if (Runtime.CallingScriptHash != Oracle.Hash) | ||
throw new System.Exception("Unauthorized!"); | ||
Storage.Put(Storage.CurrentContext, PreData, result); | ||
} | ||
} | ||
} |
30 changes: 30 additions & 0 deletions
30
tests/Neo.SmartContract.Framework.UnitTests/Services/OracleTest.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
using System.Security.Cryptography; | ||
using Microsoft.VisualStudio.TestTools.UnitTesting; | ||
using Neo.Network.P2P.Payloads; | ||
using Neo.SmartContract.TestEngine; | ||
using Neo.VM; | ||
using Neo.Wallets; | ||
|
||
namespace Neo.SmartContract.Framework.UnitTests.Services | ||
{ | ||
[TestClass] | ||
public class OracleTest | ||
{ | ||
private TestEngine.TestEngine _engine; | ||
|
||
[TestInitialize] | ||
public void Init() | ||
{ | ||
_engine = new TestEngine.TestEngine(); | ||
_engine.AddEntryScript(Utils.Extensions.TestContractRoot + "Contract_IOracle.cs"); | ||
} | ||
|
||
[TestMethod] | ||
public void Test_OracleResponse() | ||
{ | ||
_engine.Reset(); | ||
var result = _engine.ExecuteTestCaseStandard("onOracleResponse", "http://127.0.0.1", "test", 0x14, "{}"); | ||
Assert.AreEqual(VMState.FAULT, _engine.State); | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add:
if (Runtime.CallingScriptHash != Oracle.Hash)
throw new System.Exception("Unauthorized!");
in the interface?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its an interface, no implementation can be added.