Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dBFT: Recovery message triggers PrepareRequest from Primary even if the timer isn't fired yet #799

Closed
AnnaShaleva opened this issue Apr 21, 2023 · 0 comments · Fixed by #801
Closed

dBFT: Recovery message triggers PrepareRequest from Primary even if the timer isn't fired yet #799

AnnaShaleva opened this issue Apr 21, 2023 · 0 comments · Fixed by #801

Comments

@AnnaShaleva
Copy link
Member

Describe the bug
See the nspcc-dev/dbft#74, please. The same bug exists in C# implementation:

neo-modules/src/DBFTPlugin/Consensus/ConsensusService.OnMessage.cs

Lines 251 to 252 in 4e31068

else if (context.IsPrimary)
SendPrepareRequest();

Expected behavior
Even on Recovery message receival, the primary node should wait until the timer fires before the subsequent PrepareRequest creation.

Platform:

  • Version: dBFT Plugin 3.5.0
@AnnaShaleva AnnaShaleva mentioned this issue Apr 21, 2023
Merged
@AnnaShaleva AnnaShaleva mentioned this issue May 10, 2023
Closed
ZhangTao1596 added a commit to ZhangTao1596/neo-modules that referenced this issue May 15, 2023
@ZhangTao1596
dbft: don't rush to send PrepareRequest when recovery (neo-project#799)
3d1e821
@ZhangTao1596 ZhangTao1596 mentioned this issue May 15, 2023
Merged
superboyiii pushed a commit that referenced this issue May 17, 2023
@ZhangTao1596
dbft: don't rush to send PrepareRequest when recovery (#799) (#801)
b639e84
@roman-khimov roman-khimov mentioned this issue Sep 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dbft: don't rush to send PrepareRequest when recovery ZhangTao1596/neo-modules
1 participant
@AnnaShaleva