remove break statement from FilterFree #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikzhang
approved these changes
Aug 24, 2018
|
Eagle eyes! I am happy to see such improvements today, really. |
|
@vncoelho Now we just need wakka akka 😄 |
|
Hey, @Edgegasm. Different contributions and @erikzhang, as always, being very careful, open and fast when it is needed. Today can be seen as a bright example about how many incredible minds are involved in this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
FilterFree, once the free transaction limit has been reached,yield breakis called, preventing further iteration on the the list of transactions. Hence, blocks become limited to contain only the number of transactions that were returned before that point, instead of iterating all the way toMaxTransactionsPerBlock. This change removes that statement so that any additional transactions with fees attached may be processed as theforeachstatement continues.