Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime secure random number for N3 #670

Closed
wants to merge 36 commits into from
Closed

Runtime secure random number for N3 #670

wants to merge 36 commits into from

Conversation

Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Oct 31, 2021

This pr implement secure random number for N3 at runtime.

#601
#637
#596
neo-project/neo#2504

@Jim8y Jim8y marked this pull request as draft October 31, 2021 23:47
@Jim8y Jim8y changed the title Secure random Runtime secure random for N3 Oct 31, 2021
@Jim8y Jim8y changed the title Runtime secure random for N3 Runtime secure random number for N3 Oct 31, 2021
* master:
  fix auto start (#664)
  MakeTransactionAsync overload with systemFee param (#661)
…to secure-random

* 'secure-random' of github.com:Liaojinghui/neo-modules:
@Jim8y
Copy link
Contributor Author

Jim8y commented Nov 2, 2021

our solution
image

Others solution requires third party RNG and need two rounds to process:
image

@roman-khimov
Copy link
Contributor

Transaction list exchange will have serious performance consequences. And the worst thing is that it would affect the performance most exactly when we need it most, under some stress, because transaction pressure tends to lead to a greater deal of unsynchrony between the nodes. Notice also that for high-performing networks (which inevitably have to allow tens of thousands of transactions in a block) that could easily mean exchanging 1MB+ messages in this phase further complicating the situation.

I'd suggest trying this in neo-bench, four CNs and especially 7+2 scenario. 7+2 was added quite recently and it makes all nodes look bad because the network becomes highly unsynchronized, but that's exactly what makes this case more realistic and interesting (we've not optimized for it yet).

@Jim8y
Copy link
Contributor Author

Jim8y commented Nov 2, 2021

@roman-khimov Thank you very much for your suggestion roman, that would be a great help.

Ashuaidehao and others added 3 commits December 15, 2021 10:27
* init

* upgrade neo

* useDiagnostic

* Update RpcServer.SmartContract.cs

* invoke tree

* add event

* Add storage changes

* Update nuget

* rename event state

* Unify

* update neofs

* fix json

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Erik Zhang <erik@neo.org>
Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
* add in file copyright

* fix the copyright

* update copyright start year

* Delete copyright.sh

* Delete copyright.txt

Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
Co-authored-by: Erik Zhang <erik@neo.org>
* init

* refac

Co-authored-by: Shargon <shargon@gmail.com>
@Jim8y Jim8y mentioned this pull request Jan 17, 2022
@Jim8y Jim8y changed the base branch from master to develop February 8, 2022 19:35
shargon and others added 5 commits March 9, 2022 09:49
* add log when exception happens under debug mode (#686)

* Revert "add log when exception happens under debug mode (#686)" (#689)

This reverts commit 7b661e5.

* Prevent SSRF

* Update OracleHttpsProtocol.cs

* remove goto

* Remove redundant code

* Remove empty line

Co-authored-by: Jinghui Liao <jinghui@wayne.edu>
Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
Co-authored-by: Erik Zhang <erik@neo.org>
* add log when exception happens under debug mode (#686)

* Revert "add log when exception happens under debug mode (#686)" (#689)

This reverts commit 7b661e5.

* limit free gas

* update limit

Co-authored-by: Jinghui Liao <jinghui@wayne.edu>
Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
Follow ExecFeeFactor changes for MaxBlockSystemFee and make it possible to fit
5K transactions into the block. Related to neo-project/neo-node#850.

Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
@erikzhang erikzhang changed the base branch from develop to master May 19, 2022 04:56
@Jim8y Jim8y closed this by deleting the head repository Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants