Just extend by factor if commit is from current view

[vncoelho]

Extend by factor with a commit from previous view will only de-synchronize nodes of current view, instead of acting as a factor for ensuring coherence between nodes.

[roman-khimov]

Looks like we've had this behavior for some time already, seems to work fine:
nspcc-dev/dbft@57394a1
nspcc-dev/dbft#16

[vncoelho]

It is good that you noticed that @roman-khimov, and also good to know that you already modified in the neo-go version.
It would had been nice if you had communicated it here at the time, in order to keep nodes with same protocol.

In our vision, this change is needed to keep consistent with the mechanism that it is made for.

[roman-khimov]

It would had been nice if you had communicated it here at the time, in order to keep nodes with same protocol.

Vitor, you're absolutely right and in general we do report on things we try/implement (like neo-project/neo#2057 or neo-project/neo#2058 or many other non-dBFT things), it's just this particular change was made quite a while ago, we were not entirely sure on it and we didn't track these deviations properly back then.

But now it's more than two years old, kinda tested, should be fine to have it here too.

[vncoelho]

@roman-khimov, sounds good, you guys are doing a great job!