Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neo v3.5.0 Checklist #2811

Closed
superboyiii opened this issue Sep 5, 2022 · 19 comments
Closed

Neo v3.5.0 Checklist #2811

superboyiii opened this issue Sep 5, 2022 · 19 comments

Comments

@superboyiii
Copy link
Member

superboyiii commented Sep 5, 2022

Now we're making the checklist of neo v3.5.0 for release preparation. We plan to release v3.5.0 at the end of September.

Mandatory issues

Mandatory PRs

@neo-project/core @neo-project/developers @neo-project/ngd-seattle

@roman-khimov
Copy link
Contributor

It'd be nice to have some definitive answer on #2773 for this release. Not that it's critical, but it's a pretty simple change to me, so we should at least make some decision on it after three months in the queue (my vote would be for accepting it).

Also, we'll try to prepare patches for #1992 and #1991 (as was proposed in #2661 (comment)), those would be nice to have in 3.5.0.

Worth considering: #2789 (trivial to implement, adds some possibilities), #2764.

@roman-khimov
Copy link
Contributor

How about neo-project/neo-modules#762 and #2812?

@superboyiii
Copy link
Member Author

How about neo-project/neo-modules#762 and #2812?

Added

@devhawk
Copy link
Contributor

devhawk commented Sep 19, 2022

please add neo-project/neo-modules#763

@superboyiii
Copy link
Member Author

please add neo-project/neo-modules#763

Done.

@ZhangTao1596
Copy link
Contributor

Please add neo-project/neo-modules#765

@Jim8y
Copy link
Contributor

Jim8y commented Sep 24, 2022

This pr #2569 has being there for one year, and it fixes the crash while file in use issue, is that possible to add this one as well?

To reproduce the issue, reinstall applicationlogs right after you start the console. I think @nicolegys has experienced this issue many times.

image

@superboyiii
Copy link
Member Author

This pr #2569 has being there for one year, and it fixes the crash while file in use issue, is that possible to add this one as well?

To reproduce the issue, reinstall applicationlogs right after you start the console. I think @nicolegys has experienced this issue many times.

image

Done

@superboyiii
Copy link
Member Author

Please add neo-project/neo-modules#765

Done

@devhawk
Copy link
Contributor

devhawk commented Oct 4, 2022

any chance of adding neo-project/neo-modules#768? It should be a pretty minor fix

@superboyiii
Copy link
Member Author

any chance of adding neo-project/neo-modules#768? It should be a pretty minor fix

Done

@devhawk
Copy link
Contributor

devhawk commented Oct 13, 2022

Is there an updated target date for 3.5 release?

@superboyiii
Copy link
Member Author

Is there an updated target date for 3.5 release?

Too many PRs still can't be merged. We have to filter some of these to ensure 3.5 can be released. What do you think?

@ixje
Copy link
Contributor

ixje commented Oct 19, 2022

Can we please include neo-project/neo-vm#493

@devhawk
Copy link
Contributor

devhawk commented Oct 20, 2022

Is there an updated target date for 3.5 release?

Too many PRs still can't be merged. We have to filter some of these to ensure 3.5 can be released. What do you think?

I'm on the road for campus tour so I'm not in a position to review current state. @shargon and @roman-khimov are likely in a better position to judge this

@shargon
Copy link
Member

shargon commented Oct 20, 2022

For me Fix assert is an important one

@devhawk
Copy link
Contributor

devhawk commented Nov 16, 2022

@superboyiii can we include neo-project/neo-devpack-dotnet#770 in 3.5? It's a minor update to the debug info

@devhawk
Copy link
Contributor

devhawk commented Nov 18, 2022

FYI, neo-project/neo-devpack-dotnet#770 is ready to merge

@mialbu mialbu mentioned this issue Dec 5, 2022
5 tasks
@superboyiii
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants