add hardfork settings to getversion call #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks ok to me, But you didn't update the here is the code you need to update as well https://github.com/neo-project/neo-modules/blob/master/src/RpcClient/Models/RpcVersion.cs |
|
Thanks @cschuchardt88. I'm AFK till Monday so will push the update then. |
No rush this wont come out until 3.7.0, Its on the checklist. |
Jim8y
approved these changes
Sep 14, 2023
shargon
approved these changes
Sep 15, 2023
Jim8y
added a commit
to Jim8y/neo-modules
that referenced
this pull request
Sep 15, 2023
* master: add hardfork settings to getversion (neo-project#823) # Conflicts: # src/NeoService/NeoService.Node.cs
This was referenced Sep 15, 2023
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Oct 12, 2023
Port neo-project/neo-modules#823. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Oct 12, 2023
Port neo-project/neo-modules#823. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Oct 13, 2023
Port neo-project/neo-modules#823. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Oct 16, 2023
Port neo-project/neo-modules#823. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #822