Added hardfork to RpcClient

[cschuchardt88]

Added hardfork to RpcClient and tested

This is for #823 implementation of hardfork settings in getversion rpc method.

[roman-khimov]

BTW, speaking of #822, can we avoid HF_ prefixes here? It's hardforks section already.

[cschuchardt88]

but it based off Enum Hardfork, So its parses the name, i guess i could put value, i believe that works.

[cschuchardt88]

oh i see what your saying, Thats how its used in #823.

public enum Hardfork : byte
{
    HF_Aspidochelone,
    HF_Basilisk
}

[roman-khimov]

Yeah, it's not a client problem and not something client should be bothered with. It's just that I've only noticed it here. But server-side it'd probably be a bit better.

[cschuchardt88]

neo-modules/src/RpcServer/RpcServer.Node.cs

Line 88 in 63e3ec3

forkJson["name"] = hf.Key;

Code uses key of the enum which in our case is HF_Aspidochelone and HF_Basilisk. We would have to change the server to use the value instead. If you would like me to proceed in changing the server let me know.

Edit: I feel that you think the server didn't implement this. but it did, thats why im doing this. Yes i do think they merged it too fast #823.

[shargon]

Yeah, it's not a client problem and not something client should be bothered with. It's just that I've only noticed it here. But server-side it'd probably be a bit better.

Why we need it in server? We can remove it from both

[cschuchardt88]

remember this #823 someone merged it. To late in 3.6.1

[Jim8y]

Good to go? ifs its already in the server.