Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Upgrade dependencies and target frameworks #477

Merged
merged 9 commits into from
Nov 26, 2019
Merged

Upgrade dependencies and target frameworks #477

merged 9 commits into from
Nov 26, 2019

Conversation

shargon
Copy link
Member

@shargon shargon commented Oct 20, 2019 •
edited

@shargon shargon mentioned this pull request Oct 20, 2019
Closed
@erikzhang
Copy link
Member

We should wait for .NET Standard 2.1.

@shargon
Copy link
Member Author

shargon commented Oct 21, 2019

But .NET Standard 2.1 was released, isn't it?

@erikzhang
Copy link
Member

We should upgrade in this order:

neo-vm -> netstandard2.1
neo -> netstandard2.1
neo-cli -> netcoreapp3.0
neo-gui -> netcoreapp3.0 (Microsoft.NET.Sdk.WindowsDesktop)
other projects

@shargon shargon changed the title Dotnet 3.0 Upgrade dependencies and target frameworks Oct 23, 2019
lock9
lock9 previously approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@lock9 lock9 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using this PR to test neo-project/neo#1178 and I can confirm that this works properly. Please wait for neo-project/neo#1178 before merging.

@lock9 lock9 mentioned this pull request Nov 7, 2019
Merged
@erikzhang erikzhang merged commit 72361dd into neo-project:master Nov 26, 2019
@shargon shargon deleted the dotnet-3x branch November 26, 2019 08:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikzhang erikzhang erikzhang approved these changes

@lock9 lock9 lock9 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to dotnet 3.0
3 participants
@shargon @erikzhang @lock9