This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Remove address version config #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can just remove the field, and it will be set to the default value from Neo.dll. |
|
If mainnet and testnet have the same value, i am agree with @erikzhang |
lock9
reviewed
Nov 28, 2019
erikzhang
approved these changes
Nov 29, 2019
shargon
approved these changes
Nov 29, 2019
Jim8y
pushed a commit
to Jim8y/neo-node
that referenced
this pull request
Aug 18, 2021
…uture blocks received at the same height (neo-project#489)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change NEO 3 version address to 53, this will produce that neo address starts with N.
Needs neo-project/neo#1299
Closes neo-project/neo#993 neo-project/neo#1017