Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Allow import or export blocks #502

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Allow import or export blocks #502

merged 1 commit into from
Dec 9, 2019

Conversation

erikzhang
Copy link
Member

No description provided.

Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @erikzhang, I do know yet if this will be as flexible as the plugin. however, it makes sense to be merged here.

@cloud8little
Copy link
Contributor

@vncoelho @erikzhang I will have a test first and please hold on the merging.

@cloud8little
Copy link
Contributor

Test scenarios all passed:
neo-cli: master #501 + pr 502
neo: 3.0.0-CI00817

os: ubuntu 18.04
current best height: 533

  1. export block Pass
neo> export block
[533/533]
  1. export block 0 30 Pass
  2. export block 30 Pass
  3. export block 0 30 -> export block 30 100, delete seed node in protocol.json, the highest block reach to 129
neo> export block 0 30
[29/29]
neo> export block 30 100
[129/129]
  1. current best height: 414 Pass
neo> export block 450
neo> export block 0 -1
error: Value was either too large or too small for a UInt32.
neo> export block 410 -1
error: Value was either too large or too small for a UInt32. 

@erikzhang
Copy link
Member Author

@cloud8little Merge?

Copy link
Contributor

@cloud8little cloud8little left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge from QA's perspective.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants