This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Show utilitary methods for Neo-Cli #546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thacryba
force-pushed
the
show-utilitary-methods
branch
2 times, most recently
from
751357e
to
8ebb90c
Compare
meevee98
force-pushed
the
show-utilitary-methods
branch
from
8ebb90c
to
924e4d8
Compare
|
@Thacryba I think the second function is very useful. However, it hasn't decompile tx compeletely. So op codes haven't be recognized yet. And since the json output can be very long in cli, I think it's more suitable to be made into rpcserver plugin and the first one and the third one are already existed. I recommend to improve the second one and made txid as a param in RPC. |
vncoelho
reviewed
May 15, 2020
| /// <param name="contractHash"></param> | ||
| /// <returns></returns> | ||
| [ConsoleCommand("show contract", Category = "Show Commands")] | ||
| private void OnShowContract(string contractHash) |
There was a problem hiding this comment.
Perhaps this could be on the Plugin and also be called through RPC.
vncoelho
reviewed
May 15, 2020
| /// <param name="desiredCount"></param> | ||
| /// <returns></returns> | ||
| [ConsoleCommand("show last-transactions", Category = "Show Commands")] | ||
| private void OnShowLastTransactions(uint desiredCount) |
There was a problem hiding this comment.
Perhaps this could be on the Plugin and also be called through RPC.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update from #455 and complementing #535.
Some changes were made:
Adding the command show last-block:
Adding the block index on show last-transactions:
Changing the time format in show block:
It can be merged after #536.