Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check dotnet format in travis #198

Merged
merged 16 commits into from Sep 13, 2019

Conversation

@shargon
Copy link
Member

commented Aug 25, 2019

This will prevent to push any format error

Related to neo-project/neo#982

@shargon

This comment has been minimized.

Copy link
Member Author

commented Aug 25, 2019

@igormcoelho Works as expected, this project require a format

shargon added 2 commits Aug 25, 2019

@shargon shargon requested review from lock9 and vncoelho Aug 25, 2019

vncoelho added 2 commits Aug 26, 2019
@vncoelho

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

We still need to manually fix tests/neo-vm.Tests/UtDebugger.cs

vncoelho added 3 commits Aug 26, 2019
@vncoelho
Copy link
Member

left a comment

Almost there, let's just manually fix that one

@vncoelho
Copy link
Member

left a comment

It looks good now.

@codecov-io

This comment has been minimized.

Copy link

commented Aug 26, 2019

Codecov Report

Merging #198 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   79.32%   79.32%           
=======================================
  Files          16       16           
  Lines        1422     1422           
=======================================
  Hits         1128     1128           
  Misses        294      294
Impacted Files Coverage Δ
src/neo-vm/Types/Integer.cs 78.12% <ø> (ø) ⬆️
src/neo-vm/ExecutionEngine.cs 70.79% <ø> (ø) ⬆️
src/neo-vm/Types/Array.cs 53.57% <ø> (ø) ⬆️
src/neo-vm/Types/Map.cs 37.28% <ø> (ø) ⬆️
src/neo-vm/Instruction.cs 100% <ø> (ø) ⬆️
src/neo-vm/Script.cs 100% <ø> (ø) ⬆️
src/neo-vm/RandomAccessStack.cs 100% <ø> (ø) ⬆️
src/neo-vm/ScriptBuilder.cs 100% <ø> (ø) ⬆️
src/neo-vm/Debugger.cs 96.92% <ø> (ø) ⬆️
src/neo-vm/Types/Struct.cs 100% <ø> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fd56dd...be51ea9. Read the comment docs.

shargon and others added 2 commits Aug 26, 2019
@igormcoelho
Copy link
Contributor

left a comment

Good for me, if travis tests pass that's fine.

This one has no rush I guess... let's wait for more interactions here.

@shargon

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

why pass with wrong lf?

.editorconfig Outdated Show resolved Hide resolved
@shargon

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2019

Anyone could review this pull request?

@vncoelho
Copy link
Member

left a comment

Sorry for the delay @shargon, we will revise asap and check the format. The travis is good to me since we already checked that before.

@belane
belane approved these changes Sep 9, 2019

@shargon shargon requested a review from vncoelho Sep 10, 2019

Change done

@lock9 lock9 merged commit 11dc29c into master Sep 13, 2019

2 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.