Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Remove BOM from *.json test files #199

Closed
wants to merge 3 commits into from

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Sep 6, 2019

Some of the json tests have BOM marker at the beginning of the file (as was also noted in the first comment #94 ). I see no value in it and it has created some difficulties when trying to parse them in Go.

@codecov-io
Copy link

codecov-io commented Sep 6, 2019

Codecov Report

Merging #199 into dotnet-format will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           dotnet-format     #199   +/-   ##
==============================================
  Coverage          79.32%   79.32%           
==============================================
  Files                 16       16           
  Lines               1422     1422           
==============================================
  Hits                1128     1128           
  Misses               294      294

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be51ea9...47ac2c4. Read the comment docs.

@shargon
Copy link
Member

shargon commented Sep 6, 2019

We should wait for #198 before merge this

@erikzhang
Copy link
Member

Why #198 passes without these changes?

@shargon
Copy link
Member

shargon commented Sep 10, 2019

I think that these changes are repeated, because for example APPEND.json has the same changes in both PR

https://github.com/neo-project/neo-vm/pull/198/files#diff-2d9175bb65d9e89a9284985533bea646
https://github.com/neo-project/neo-vm/pull/199/files#diff-2d9175bb65d9e89a9284985533bea646

@erikzhang
Copy link
Member

Then I will rebase it to #198 and see if this is the case.

@erikzhang erikzhang changed the base branch from master to dotnet-format September 10, 2019 07:47
@erikzhang
Copy link
Member

No luck.

@shargon
Copy link
Member

shargon commented Sep 10, 2019

The file is the same, but still there 🤔

@shargon
Copy link
Member

shargon commented Sep 10, 2019

I checked APPEND.json and is exactly the same in both branches

Sha-256=0071C77CE46E4EB47F3C328731B76A190FBADE373718385FF835AF466AE110EB

Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we modify the Travis for checking these files as well?

Which command did you use, @fyrchik?

@shargon
Copy link
Member

shargon commented Sep 12, 2019

I think that travis is checking these files now, but i don't know why appears as changed if is the same as my pull request.
@lock9 any idea?

@lock9
Copy link
Contributor

lock9 commented Sep 13, 2019

Hi, I think this is not needed

@erikzhang erikzhang changed the base branch from dotnet-format to master September 14, 2019 08:18
@erikzhang erikzhang closed this Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants