-
Notifications
You must be signed in to change notification settings - Fork 148
Conversation
Codecov Report
@@ Coverage Diff @@
## dotnet-format #199 +/- ##
==============================================
Coverage 79.32% 79.32%
==============================================
Files 16 16
Lines 1422 1422
==============================================
Hits 1128 1128
Misses 294 294 Continue to review full report at Codecov.
|
We should wait for #198 before merge this |
Why #198 passes without these changes? |
I think that these changes are repeated, because for example https://github.com/neo-project/neo-vm/pull/198/files#diff-2d9175bb65d9e89a9284985533bea646 |
Then I will rebase it to #198 and see if this is the case. |
No luck. |
The file is the same, but still there 🤔 |
I checked
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we modify the Travis for checking these files as well?
Which command did you use, @fyrchik?
I think that travis is checking these files now, but i don't know why appears as changed if is the same as my pull request. |
Hi, I think this is not needed |
Some of the json tests have BOM marker at the beginning of the file (as was also noted in the first comment #94 ). I see no value in it and it has created some difficulties when trying to parse them in
Go
.