Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Expand documentation of NEWARRAY and NEWSTRUCT opcodes #200

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Sep 6, 2019

PR #91 implemented ability to convert from Array to Struct and vice
versa.
#91

This PR adds proper doc comments.

PR neo-project#91 implemented ability to convert from Array to Struct and vice
versa.
neo-project#91
@codecov-io
Copy link

codecov-io commented Sep 6, 2019

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   79.32%   79.32%           
=======================================
  Files          16       16           
  Lines        1422     1422           
=======================================
  Hits         1128     1128           
  Misses        294      294

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b9fc13...351d026. Read the comment docs.

@roman-khimov
Copy link
Contributor

roman-khimov commented Sep 8, 2019

I think you should also mention here the thing that was discussed in nspcc-dev/neo-go#360 --- after #91 NEWARRAY on array and NEWSTRUCT on struct are effectively noops.

@shargon shargon merged commit 2fd56dd into neo-project:master Sep 9, 2019
@devhawk
Copy link
Contributor

devhawk commented Sep 9, 2019

@shargon we should make sure https://github.com/neo-ngd/NEO3-Development-Guide is up to date with correct docs. Can you either file an issue or make sure those docs are up to date w/ latest source changes?

@shargon
Copy link
Member

shargon commented Sep 11, 2019

@devhawk NEWARRAY and NEWSTRUCT must be updated in https://github.com/neo-ngd/NEO3-Development-Guide/tree/master/en/NeoVM#newarray because now in order to convert between types, can receive an Array and a struct.

Also was added some opcodes in the enum: from PUSHBYTES1 to PUSHBYTES75

@devhawk
Copy link
Contributor

devhawk commented Sep 12, 2019

You can file bugs on that repo: https://github.com/neo-ngd/NEO3-Development-Guide/issues

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants