Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Upgrade dependencies and target frameworks #216

Merged
merged 11 commits into from
Oct 23, 2019
Merged

Upgrade dependencies and target frameworks #216

merged 11 commits into from
Oct 23, 2019

Conversation

erikzhang
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 22, 2019

Codecov Report

Merging #216 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #216   +/-   ##
=======================================
  Coverage   79.57%   79.57%           
=======================================
  Files          17       17           
  Lines        1444     1444           
=======================================
  Hits         1149     1149           
  Misses        295      295

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f8dff8...8f9303a. Read the comment docs.

@shargon
Copy link
Member

shargon commented Oct 22, 2019

Seems that dotnet-format is not working on mac/3x ..

@shargon
Copy link
Member

shargon commented Oct 22, 2019

I opened a issue in dotnet dotnet/format#400

@erikzhang
Copy link
Member Author

I have a question: why do we need both linux and osx in travis?

@shargon
Copy link
Member

shargon commented Oct 22, 2019

We have two quick options:

  • Remove osx
  • Check dotnet-format only on linux

@erikzhang
Copy link
Member Author

I prefer to remove osx directly.

.travis.yml Outdated Show resolved Hide resolved
shargon
shargon previously approved these changes Oct 22, 2019
shargon
shargon previously approved these changes Oct 22, 2019
@erikzhang
Copy link
Member Author

I think we should move dotnet-format from before_script to script.

@shargon
Copy link
Member

shargon commented Oct 22, 2019

If dotnet-format fail, will travis continue if it is under script?

@erikzhang
Copy link
Member Author

If dotnet-format fail, will continue if is it under script?

I think travis won't continue if dotnet-format fails in script.

@shargon shargon merged commit 4c43947 into master Oct 23, 2019
@shargon shargon deleted the targetframework branch October 23, 2019 09:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants