Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

New flow-control Opcodes #254

Merged
merged 9 commits into from
Dec 8, 2019
Merged

New flow-control Opcodes #254

merged 9 commits into from
Dec 8, 2019

Conversation

erikzhang
Copy link
Member

@erikzhang erikzhang commented Dec 7, 2019 •
edited

Closes #236

shargon
shargon reviewed Dec 7, 2019
View reviewed changes
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add some [MethodImpl(MethodImplOptions.AggressiveInlining)] in ExecuteCall and ExecuteJump

src/neo-vm/ExecutionEngine.cs Outdated Show resolved Hide resolved
@erikzhang
Copy link
Member Author

Ready

@shargon
Copy link
Member

shargon commented Dec 7, 2019

The code looks good, but what do you think if we use the VarInt mechanism? We can save some bytes in _L

@erikzhang
Copy link
Member Author

I think fixed prefix is more efficient in VM.

@erikzhang erikzhang merged commit ac6afb1 into master Dec 8, 2019
@erikzhang erikzhang deleted the 3.0/opcode-flow-control branch December 8, 2019 07:20
@roman-khimov roman-khimov mentioned this pull request Apr 22, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redesign flow-control opcodes
2 participants
@erikzhang @shargon