New slot opcodes #264
New slot opcodes #264
Conversation
|
@shargon Can you help with the UT? I don't know how to check the slots in the json. |
|
I will do it |
|
Ready to merge. |
There was a problem hiding this comment.
I don't have enough knowledge to approve this PR, but I can definitely say that I love it. It simplifies a lot the VM, making it much easier for other developers to understand, maintain and maybe even update.
Again, I loved this PR, I wish I had enough knowledge to approve it.
| /// </summary> | ||
| FROMALTSTACK = 0x6C, |
There was a problem hiding this comment.
Do we have any operation that takes value from Slot and "removes" it? I mean, takes from last index of slot and reduces its size? It could be similar to the FROMALTSTACK... but I guess on practice we won't need it, compilers should be able to generate slot logic directly, instead of double stacks.
There was a problem hiding this comment.
No. Slot size can't be changed.
| ExecuteTest(ut); | ||
| try | ||
| { | ||
| ExecuteTest(ut); |
There was a problem hiding this comment.
New exceptions being launched now @shargon ?
There was a problem hiding this comment.
Yes, because was hard to detect for me which file was wrong.
|
|
Closes #246