-
Notifications
You must be signed in to change notification settings - Fork 146
Conversation
@shargon Can you help with the UT? I don't know how to check the slots in the json. |
I will do it |
Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have enough knowledge to approve this PR, but I can definitely say that I love it. It simplifies a lot the VM, making it much easier for other developers to understand, maintain and maybe even update.
Again, I loved this PR, I wish I had enough knowledge to approve it.
/// </summary> | ||
FROMALTSTACK = 0x6C, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any operation that takes value from Slot and "removes" it? I mean, takes from last index of slot and reduces its size? It could be similar to the FROMALTSTACK... but I guess on practice we won't need it, compilers should be able to generate slot logic directly, instead of double stacks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Slot size can't be changed.
ExecuteTest(ut); | ||
try | ||
{ | ||
ExecuteTest(ut); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New exceptions being launched now @shargon ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because was hard to detect for me which file was wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! interesting shift from double-stack model to a slot model. Easier for compilers and better stack utilization.
|
Closes #246