This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
Get base object from InteropInterface #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to get the base object from `InteropInterface` without known the type
shargon
added a commit
to osmirnov/neo-sharp
that referenced
this pull request
Nov 20, 2018
**Not tested**, first draft This two PR could help with some problems - neo-project/neo-vm#64 - neo-project/neo-vm#66
igormcoelho
reviewed
Nov 20, 2018
| public object GetInterface() | ||
| { | ||
| return _object; | ||
| } |
There was a problem hiding this comment.
The little I know of C# makes me wonder if it will complain on returning a private member in a public function... isn't this an issue? For C++ that's fine :)
There was a problem hiding this comment.
Another thing, pay attention to not deserialize this object to byte[]... some time ago I noticed that it would be catastrophic to be able to serialize/deserialize such interfaces.
Merged
|
Closed for #67 |
osmirnov
added a commit
to CityOfZion/neo-sharp
that referenced
this pull request
Nov 28, 2018
* initial attempt to persist invoc tx * added message container * removed message provider * initial NeoVM support * moved StateMachine and StateReader from NEO * adjusted namespaces * drop explicit deps from NEO.VM * update NuGet * Try to unify with current interfaces **Not tested**, first draft This two PR could help with some problems - neo-project/neo-vm#64 - neo-project/neo-vm#66 * Remove `this` * Workaround InteropInterface * Syscall hashes * Some fixes * NeoVM.dll compiled (for advance without the last nuget) * Clean code * Clean code * Clean code * Free context * change interop service * convert abstract classes to base classes * return null for ToByteArray when no conversion * Small fix * Test AVM virtual contract add 0x0066 testinvoke 0x9e5bf7f291e4d8edd25e7b3c790c6f11590f9754 Application * Clean code * Centralize Gas increase * Delegate SYSCALL gas to InteropService * Our State is not a Flag * Use nuGet package 2.3.3.1 * Fix the fix * Remove IDisposable from ExecutionContext and Stacks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to get the base object from
InteropInterfacewithout known the type