Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Improve the performance of NeoVM #95

Merged
merged 8 commits into from
Mar 27, 2019
Merged

Improve the performance of NeoVM #95

merged 8 commits into from
Mar 27, 2019

Conversation

erikzhang
Copy link
Member

No description provided.

@erikzhang erikzhang requested a review from shargon March 26, 2019 08:48
shargon
shargon reviewed Mar 26, 2019
View reviewed changes
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to add some Inline Attributes for methods like ToByteArray

src/neo-vm/Unsafe.cs Show resolved Hide resolved
src/neo-vm/Unsafe.cs Show resolved Hide resolved
src/neo-vm/Unsafe.cs Show resolved Hide resolved
@shargon
Add comment
8684e83 
Add a comment in order to prevent the use in the future without check the length previously
@shargon
Update Unsafe.cs
4b7e91e
@shargon
Copy link
Member

shargon commented Mar 26, 2019

I will add some UT, and i will approve it, good move :)

@erikzhang
Copy link
Member Author

@shargon Can I merge this?

@shargon
Copy link
Member

shargon commented Mar 27, 2019

Give me 2 hours for try to do some UT

@shargon
Copy link
Member

shargon commented Mar 27, 2019

We can add

[MethodImpl(MethodImplOptions.AggressiveInlining)]

In all ToByteArray methods?

@erikzhang
Copy link
Member Author

AggressiveInlining has no effect on virtual methods.

@shargon
Some ut for performance PR (#100)
39f8517 
* SHL and SHR

* SIZE

* Change category

* Typo
@shargon
Copy link
Member

shargon commented Mar 27, 2019

I just want to add SUBSTR test and it's done :)

@shargon shargon merged commit c45330e into master Mar 27, 2019
@shargon shargon deleted the performance branch March 27, 2019 11:54
@ixje ixje mentioned this pull request Apr 17, 2019
Merged
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikzhang @shargon