Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SQLiteWallet #752

Merged
merged 4 commits into from
Sep 5, 2022
Merged

Add SQLiteWallet #752

merged 4 commits into from
Sep 5, 2022

Conversation

erikzhang
Copy link
Member

No description provided.

@erikzhang erikzhang mentioned this pull request Aug 26, 2022
Merged
@nicolegys
Copy link
Contributor

nicolegys commented Aug 31, 2022 •
edited
Loading

1.Find e_sqlite3.dll in \publish\runtimes\win-x64\native after publishing SQLiteWallet, need to copy this file to neo-cli folder.
2.
1661918719484
A description would be nice~
3.
1661918938588
Need to create a new pr in neo-node, because the warning content needs to be changed when someone trying to create/open a sqlite wallet without SQLiteWallet intalled.

@nicolegys
Copy link
Contributor

Functional test pass:
create/open .db3 wallet
create address
open old .db3 wallet(v3.3.1, v3.4.0)
upgrade .db3 wallet

There is no significant change in performance compared with v3.4.0 (on win10).

  100 addresses 1000 addresses 3000 addresses
open wallet 40s 407s 1192s
create address 48 s 412s 1662s
upgrade wallet 78s 770s 2287s

nicolegys
nicolegys previously approved these changes Sep 1, 2022
View reviewed changes
superboyiii
superboyiii previously approved these changes Sep 5, 2022
View reviewed changes
@superboyiii
Copy link
Member

This PR is OK. Maybe we need another to improve performance. @erikzhang

@superboyiii superboyiii mentioned this pull request Sep 5, 2022
Closed
@erikzhang erikzhang dismissed stale reviews from superboyiii and nicolegys via 47b5ad5 September 5, 2022 05:26
@erikzhang erikzhang merged commit 7aa6d94 into master Sep 5, 2022
@erikzhang erikzhang deleted the sqlite-wallet branch September 5, 2022 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superboyiii superboyiii superboyiii left review comments

@nicolegys nicolegys nicolegys left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikzhang @nicolegys @superboyiii