Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why use akka.net for p2p?it is slow. #611

Closed
lightszero opened this issue Feb 26, 2019 · 11 comments
Closed

why use akka.net for p2p?it is slow. #611

lightszero opened this issue Feb 26, 2019 · 11 comments
Labels
discussion Initial issue state - proposed but not yet accepted enhancement Type - Changes that may affect performance, usability or add new features to existing modules. p2p Module - peer-to-peer message exchange and network optimisations, at TCP or UDP level (not HTTP).

Comments

@lightszero
Copy link
Member

akka.net remote translate speed is about 40M/s,it is not a very good number.
and akka.net 's actor ontell is in single thread,it is not very good for performance.
@vncoelho
Copy link
Member

vncoelho commented Feb 26, 2019 •
edited
Loading

Sounds worth discussion.
But we should notice that after Akka the code turned into hundreds times faster, so, it came with several improvements (some might not be optimal).

In this sense, I agree with you Lights, it is always time to wonder.
Codes can always be refined and each time more paralelized. ahuahahauehahau

@erikzhang erikzhang added the discussion Initial issue state - proposed but not yet accepted label Feb 26, 2019
@lightszero
Copy link
Member Author

lightszero commented Feb 27, 2019 •
edited
Loading

NEO use akka.net on lots of modules. i just try to find out is there akka.net is right for p2p or not.
I will do some test project to show some numbers.

@shargon
Copy link
Member

shargon commented May 9, 2019

any news @lightszero?

@shargon
Copy link
Member

shargon commented Jul 23, 2019

ping @lightszero

@lock9
Copy link
Contributor

lock9 commented Aug 12, 2019

Hi @lightszero, can we close this and reopen once we have a proposed solution? It is because I don't see us dropping in the next months

@lock9 lock9 added enhancement Type - Changes that may affect performance, usability or add new features to existing modules. house-keeping Small enhancements that need to be done in order to keep the project organised p2p Module - peer-to-peer message exchange and network optimisations, at TCP or UDP level (not HTTP). and removed potential enhancement house-keeping Small enhancements that need to be done in order to keep the project organised labels Aug 12, 2019
@vncoelho vncoelho mentioned this issue Sep 20, 2019
Closed
@Tommo-L
Copy link
Contributor

Tommo-L commented Sep 20, 2019

We will test it, and we also can consider this library https://libp2p.io/

@vncoelho
Copy link
Member

vncoelho commented Sep 24, 2019 •
edited
Loading

@Tommo-L, This library looks interesting, would this work embedded with the actors or it would replace P2P Akka actors?

@Tommo-L
Copy link
Contributor

Tommo-L commented Sep 25, 2019

Currently, @eryeer is testing akka.net and this library. The test report will be generated later.

@igormcoelho
Copy link
Contributor

igormcoelho commented Sep 30, 2019 •
edited
Loading

@Tommo-L great idea to use a third-party consolidated library... I took a look at libp2p a while ago. Since it's sponsored by IPFS project, I wondered if that was a good strategical decision... but if it's good enough, let's use it! (that's my opinion)
Then, another issue I see now is that it doesn't have a C# and C++ implementation (wat???). So, we could take a look at its specification, to see if it's better than ours (more organized/general yet possible to personalize to our case). Let's weight pros and cons. If we build a C# libp2p and use it on Neo, it may be a good contribution to blockchain ecosystem in general (as long as spec of libp2p is good enough).

One thing bothers me a lot: how is it possible that we don't have a good p2p open-source library, in all this blockchain jungle? I've tried to find a good one already, but couldn't until now...

@shargon
Copy link
Member

shargon commented Sep 30, 2019

First we can test the difference between a tcp transfer of 100mb with and without akka?

@lock9 lock9 mentioned this issue Oct 25, 2019
Closed
31 tasks
Thacryba pushed a commit to simplitech/neo that referenced this issue Feb 17, 2020
@Celia18305
Release 2.9.0 cli (neo-project#614)
5406712 
* 2.9.0

* updates for 2.9.0

* Update v2.9.0.md (neo-project#610)

Adjustment for instruction of getting nep-5 applicationlog.

* Update invokescript.md (neo-project#613)

Add tx

* Update invokefunction.md (neo-project#612)

Add tx for response.

* Create getwalletheight (neo-project#611)

Add getwalletheight api.

* updates for 2.9.0

* minor updates

* Update setup.md (neo-project#617)

Add introduction of Plugins.

* Update v2.9.0.md (neo-project#615)

Add introduction for setting config.json

* final updates

* Update v2.9.0.md (neo-project#618)

Add notes for install plugins.

* plugin related
@vncoelho
Copy link
Member

image

I believe it will be fixed now, @lightszero.
Check akkadotnet/akka.net#2378 (comment)

They just closed 2 days ago.

Time to update Akka.

@vncoelho vncoelho mentioned this issue Feb 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion Initial issue state - proposed but not yet accepted enhancement Type - Changes that may affect performance, usability or add new features to existing modules. p2p Module - peer-to-peer message exchange and network optimisations, at TCP or UDP level (not HTTP).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@igormcoelho @lightszero @shargon @erikzhang @vncoelho @lock9 @Tommo-L