Expose DbCache (for plugins, etc.) + useful Neo.IO.Helper methods #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsolman
changed the title
erikzhang
reviewed
Feb 27, 2019
| @@ -9,6 +9,8 @@ namespace Neo.IO | |||
| { | |||
| public static class Helper | |||
| { | |||
| public const int GroupingSizeInBytes = 16; | |||
There was a problem hiding this comment.
This also can be needed in code that uses Find from a plugin. I have code that needs it, because to search for a prefix one needs to add a 0 byte after every 16 characters to search for a prefix longer than this length.
There was a problem hiding this comment.
If the Find method inserted the 0 bytes after every 16 characters it wouldn’t be needed. If we change that in a subsequent PR we could change this to be internal perhaps, but for now, we need it public.
shargon
approved these changes
Feb 27, 2019
Thacryba
pushed a commit
to simplitech/neo
that referenced
this pull request
Feb 17, 2020
* 2.9.0 * updates for 2.9.0 * Update v2.9.0.md (neo-project#610) Adjustment for instruction of getting nep-5 applicationlog. * Update invokescript.md (neo-project#613) Add tx * Update invokefunction.md (neo-project#612) Add tx for response. * Create getwalletheight (neo-project#611) Add getwalletheight api. * updates for 2.9.0 * minor updates * Update setup.md (neo-project#617) Add introduction of Plugins. * Update v2.9.0.md (neo-project#615) Add introduction for setting config.json * final updates * Update v2.9.0.md (neo-project#618) Add notes for install plugins. * plugin related
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins that persist to a separate LevelDB store may want to use the
DbCachein order to cache data they will be writing to disk and exposing through RPC. One example is moving #569 to a plugin, and there are other plugins I am working on that will need it.