Renaming two variables related to Consensus Reverification of txs #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vncoelho
changed the title
|
This don't close #1148 ... |
|
@shargon, do you still believe that happens? I think the code cover that, this renaming is just for improving comprehension. Exactly the Verify and the possibility of sending specific sets of transactions solves that, consensus service is isolated from mempool in such case. |
vncoelho
changed the title
* Adding random hashes for OnGetDataMessageReceived * Adding static readonly Random * Renaming consensus RestartTasks to ConsensusTxsTask * Minor s removal * removing wrong modification on protocolhandler * Renaming restart to consensusTask * Fixing UT for protocol handler * Adding comment
vncoelho
changed the title
vncoelho
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1162 +/- ##
=======================================
Coverage 65.14% 65.14%
=======================================
Files 199 199
Lines 13598 13598
=======================================
Hits 8858 8858
Misses 4740 4740
Continue to review full report at Codecov.
|
|
Closed in favor of the improvements of PR #1183. However, the renaming of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1148
Sometimes the
Verifyis used in another context, such as by Consensus Service, which sends a set (dictionary) of transactions that theSpeakeris proposing.In this sense, not always the node
mempoolis used forVerifying/Reverifying.Thus, this renaming tries to clarify this.