Renaming RestartTasks to ConsensusTxsTask - Merged on a closed PR #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vncoelho
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1167 +/- ##
=======================================
Coverage 65.14% 65.14%
=======================================
Files 199 199
Lines 13598 13598
=======================================
Hits 8858 8858
Misses 4740 4740
Continue to review full report at Codecov.
|
|
It is not related to consensus. |
|
Why you don't group it with #1162, two PR for renaming seems weird to me |
|
They came in separate idea, @shargon, can be merged there, but @erikzhang is saying it is not related to consensus. However, it is just used there nowadays. I prefer to rename and if, in the future, we have other applications we create the tasks for them. |
vncoelho
changed the base branch from
master
to
refactoring-transaction-verify
|
merged on #1162 |
|
@shargon, maybe I will reopen this branch in another PR. |
vncoelho
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also helps for understanding #1148
@erikzhang, please consider this renaming.
RestartTaskswas a name hard to understand.In fact, that class was just used at
ConsensusService, which forces a restart ofglobalandknowhashesI believe that comprehension will improve with this.