Fix native serialize #1988
Merged
Fix native serialize #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erikzhang I only keep the neoToken changes because it will not be accessible outside of the contract, and we can have more than expected values, I also think we can also change the id of the oracles, because 32 is too small for this list. |
erikzhang
reviewed
Oct 7, 2020
Co-authored-by: Erik Zhang <erik@neo.org>
erikzhang
reviewed
Oct 11, 2020
erikzhang
reviewed
Oct 12, 2020
Tommo-L
reviewed
Oct 12, 2020
erikzhang
reviewed
Oct 13, 2020
Tommo-L
reviewed
Oct 14, 2020
erikzhang
reviewed
Oct 15, 2020
Co-authored-by: Erik Zhang <erik@neo.org>
Tommo-L
approved these changes
Oct 15, 2020
erikzhang
approved these changes
Oct 16, 2020
erikzhang
reviewed
Oct 16, 2020
| @@ -86,7 +87,7 @@ public T GetInteroperable<T>() where T : IInteroperable, new() | |||
| if (cache is null) | |||
| { | |||
| var interoperable = new T(); | |||
| interoperable.FromStackItem(BinarySerializer.Deserialize(value, 16, 34)); | |||
| interoperable.FromStackItem(BinarySerializer.Deserialize(value, ExecutionEngineLimits.Default.MaxStackSize, ExecutionEngineLimits.Default.MaxItemSize)); | |||
There was a problem hiding this comment.
I think that it's better to preserve the vm limits.
Qiao-Jin
added a commit
to Qiao-Jin/neo
that referenced
this pull request
Oct 23, 2020
Fix native serialize (neo-project#1988)
45 tasks
12 tasks
ShawnYun
pushed a commit
to ShawnYun/neo
that referenced
this pull request
Jan 8, 2021
* Fix native serialize * Update src/neo/SmartContract/Native/Oracle/OracleContract.cs Co-authored-by: Erik Zhang <erik@neo.org> * Update OracleContract.cs * Remove sorting with BigEndian * Fix foreach without sort * Fix calculate bonus * Remove foreach * Follow roman feedback * Return iterator for GetBlockedAccounts * dotnet format * Remove method and update nuget * Revert ArrayWrapper * Fix UT * Update * Use find range * Remove internal * Store blocked accounts in chunks * Changed to const * Optimize * Change to 200 and optimize * Optimize II * Optimize NeoToken changes * Clean code * One record one key * Clean code * Rename * Update IsBlocked * Remove ordering * Fix ut * Optimization * Revert include endKey * Revert include endKey * add yield break * Update NeoToken.cs * Update src/neo/SmartContract/Native/Tokens/NeoToken.cs Co-authored-by: Erik Zhang <erik@neo.org> * Remove +1 Co-authored-by: Erik Zhang <erik@neo.org>
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
* Fix native serialize * Update src/neo/SmartContract/Native/Oracle/OracleContract.cs Co-authored-by: Erik Zhang <erik@neo.org> * Update OracleContract.cs * Remove sorting with BigEndian * Fix foreach without sort * Fix calculate bonus * Remove foreach * Follow roman feedback * Return iterator for GetBlockedAccounts * dotnet format * Remove method and update nuget * Revert ArrayWrapper * Fix UT * Update * Use find range * Remove internal * Store blocked accounts in chunks * Changed to const * Optimize * Change to 200 and optimize * Optimize II * Optimize NeoToken changes * Clean code * One record one key * Clean code * Rename * Update IsBlocked * Remove ordering * Fix ut * Optimization * Revert include endKey * Revert include endKey * add yield break * Update NeoToken.cs * Update src/neo/SmartContract/Native/Tokens/NeoToken.cs Co-authored-by: Erik Zhang <erik@neo.org> * Remove +1 Co-authored-by: Erik Zhang <erik@neo.org>
ixje
added a commit
to CityOfZion/neo-mamba
that referenced
this pull request
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of #1983