Set attribute fee #2916
Merged
Set attribute fee #2916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A nice generalization. I think NotaryAssisted (from #2896) will fit into this scheme easily as well (the value could be removed from the Notary contract, doesn't matter much which contract stores it). @AnnaShaleva? |
AnnaShaleva
reviewed
Sep 19, 2023
Sure. |
Co-authored-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Co-authored-by: Anna Shaleva <shaleva.ann@nspcc.ru>
|
@superboyiii could you test it? |
Closed
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Sep 21, 2023
Port the neo-project/neo#2916. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Sep 21, 2023
Port the neo-project/neo#2916. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Sep 21, 2023
Port the neo-project/neo#2916. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Sure |
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Sep 22, 2023
Port the neo-project/neo#2916. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Sep 22, 2023
Port the neo-project/neo#2916. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Sep 22, 2023
Port the neo-project/neo#2916. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Sep 22, 2023
Port the neo-project/neo#2916. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
|
Tested. Good enough, let's move on. @shargon |
|
@shargon, it looks like this is the same case as KECAK. If this is merged like this without tag there are possibilities for attacks. Who will be responsible to monitor all CN upgrade for that and check if the syscal was not used? |
This is a fix for a public exploit. |
|
The origin of the exploit is also another problem as you known. The Conflict PR was not ready. At least, upgrade the nodes now and release a version that CN will upgrade. Do not postpone it. |
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Oct 10, 2023
Port the neo-project/neo#2916. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Oct 10, 2023
Port the neo-project/neo#2916. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Oct 10, 2023
Port the neo-project/neo#2916. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
1 task
AnnaShaleva
added a commit
to AnnaShaleva/neo
that referenced
this pull request
Oct 10, 2023
ConflictsFee logic was replaced by the generic attribute fee mechanism implemented in neo-project#2916. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Oct 12, 2023
Port the neo-project/neo#2916. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
shargon
added a commit
that referenced
this pull request
Nov 8, 2023
* Ledger: change conflict records storage scheme This commit is a part of #2907: it implements conflict records storage scheme discribed in #2907 (comment). The short scheme description: Do not store the list of conflicting signers in the Ledger's conflict record value. Instead, put each conflicting signer in the conflict record key so that the reculting key is: {Prefix_Transaction, <conflict hash>, <signer>}, and the value is {<block index>}. As an optimisation, for each conflict record store the dummy stub where the key is {Prefix_Transaction, <conflict hash>} and the value is {<block index>}. This optimisation allows to reduce DB read requests during newly-pooled transaction verification for those transactions that do not have any on-chained conflicts. Also, IsTraceableBlock check is added for on-chain conflicts verification. It is needed to avoid situations when untraceable on-chained conflict affects the newly-pooled transaction verification. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * UT_MemoryPool: remove unused test Malicious_OnChain_Conflict was constructed incorrectly (see the comment in the end of the test) and was replaced by the proper TestMaliciousOnChainConflict test in UT_Blockchain.cs way back ago in 0c06c91. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Policy: introduce fee for Conflicts attribute This commit implements Conflicts attribute policy described in #2907 (comment). Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * *: remove remnants of ConflictsFee in native Policy ConflictsFee logic was replaced by the generic attribute fee mechanism implemented in #2916. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Native: do not remove malicious conflict records during OnPersist It's OK to keep them and save O(n) operations during OnPersist. The storage taken by these malicious conflict records is properly paid anyway. See the discussion under #2913 (comment). Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Properly rewrite previously added malicious conflict if it's in the storage `engine.Snapshot.Add` doesn't allow to rewrite storage entity if it's already exist. Thus, we firstly need to remove it and afterwards to add the updated entity. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Throw proper exception if TestMaliciousOnChainConflict fails Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Optimize conflicts records storing Use Snapshot.GetAndChange instead of subsequent calls to Delete and Add. Ref. #2913 (comment). Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> --------- Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Jimmy <jinghui@wayne.edu>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Nov 20, 2023
Port the neo-project/neo#2916. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Nov 20, 2023
Port the neo-project/neo#2916. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Nov 20, 2023
Port the neo-project/neo#2916. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Nov 20, 2023
Port the neo-project/neo#2916. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Nov 21, 2023
Port the neo-project/neo#2916. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Nov 21, 2023
Port the neo-project/neo#2916. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #2913
Idea of @AnnaShaleva