Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: introduce Policy attributes pricing #3155

Merged
merged 4 commits into from
Nov 21, 2023
Merged

*: introduce Policy attributes pricing #3155

merged 4 commits into from
Nov 21, 2023

Conversation

AnnaShaleva
Copy link
Member

@AnnaShaleva AnnaShaleva commented Oct 10, 2023

Introduce Policy pricing for attributes, port the neo-project/neo#2916.

TODO:

  • Update interop deps after PR is rebased onto master before the merge.

@AnnaShaleva
Copy link
Member Author

Draft until 0.104.0 is coming.

@AnnaShaleva AnnaShaleva marked this pull request as ready for review November 20, 2023 11:36
@roman-khimov
Copy link
Member

Requires a rebase now.

@AnnaShaleva
Copy link
Member Author

Not yet ready, test is failing.

@AnnaShaleva AnnaShaleva marked this pull request as ready for review November 20, 2023 12:41
ROADMAP.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (80fcf81) 85.41% compared to head (fe9aae8) 85.37%.

❗ Current head fe9aae8 differs from pull request most recent head c6d259b. Consider uploading reports for the commit c6d259b to get more accurate results

Files Patch % Lines
pkg/core/native/policy.go 83.82% 8 Missing and 3 partials ⚠️
pkg/core/native/native_nep17.go 50.00% 2 Missing and 2 partials ⚠️
pkg/rpcclient/policy/policy.go 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3155      +/-   ##
==========================================
- Coverage   85.41%   85.37%   -0.04%     
==========================================
  Files         326      326              
  Lines       43819    43870      +51     
==========================================
+ Hits        37427    37456      +29     
- Misses       4920     4935      +15     
- Partials     1472     1479       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnnaShaleva
Copy link
Member Author

Ready for review.

ROADMAP.md Show resolved Hide resolved
pkg/core/native/policy.go Show resolved Hide resolved
pkg/core/blockchain.go Outdated Show resolved Hide resolved
pkg/core/native/native_nep17.go Outdated Show resolved Hide resolved
Port the neo-project/neo#2916.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
…erKey

Remove related methods from native Notary and add relevant code to native
Policy.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@roman-khimov roman-khimov merged commit 28ee162 into master Nov 21, 2023
12 of 16 checks passed
@roman-khimov roman-khimov deleted the apptr-pricing branch November 21, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants