Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nuget Package Icon & Symbols #3020

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Nuget Package Icon & Symbols #3020

merged 5 commits into from
Dec 12, 2023

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Dec 9, 2023 •
edited
Loading

Change Log

  • Added package icon to nuget package
  • Added snupkg symbols to nuget package

NOTE: nuget and myget require snupkg symbol format now.

Icon

image

Also you want to change your workflow. Because you are packaging up neo-cli, neo-gui and others that don't need packaging for myget and nuget; you publish the files as well.

@cschuchardt88 cschuchardt88 marked this pull request as draft December 10, 2023 00:43
@cschuchardt88 cschuchardt88 changed the title Nuget Package Icon & Symbols Update Workflow Dec 10, 2023
@cschuchardt88 cschuchardt88 changed the title Update Workflow Nuget Package Icon & Symbols Dec 10, 2023
@cschuchardt88 cschuchardt88 marked this pull request as ready for review December 10, 2023 01:42
@shargon
Copy link
Member

shargon commented Dec 10, 2023

Yes, could you remove cli and gui in nuget package?

shargon
shargon reviewed Dec 11, 2023
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
shargon
shargon reviewed Dec 11, 2023
View reviewed changes
.github/workflows/main.yml
- name : Pack (Neo)
run: |
dotnet pack ./src/Neo \
--configuration Debug \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--include-source ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does that do? Symbols? if so they get automatically generated on published.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

--include-symbols - it creates the symbols package.
--include-source - it creates the symbols package with a src folder inside containing the source files.

Copy link
Member Author

@cschuchardt88 cschuchardt88 Dec 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ya we can do that.

Copy link
Member Author

@cschuchardt88 cschuchardt88 Dec 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work see NuGet/Home#8589, spec doesnt allow it anymore, cause of the new format.

@shargon shargon merged commit 52f660a into neo-project:master Dec 12, 2023
2 checks passed
@shargon
Copy link
Member

shargon commented Dec 12, 2023

@cschuchardt88 error : 'CI01440' is not a valid version string. (Parameter 'value')

@cschuchardt88
Copy link
Member Author

ok let me look

@cschuchardt88
Copy link
Member Author

its doing same as before git rev-list --count HEAD |xargs printf "CI%05d" |xargs dotnet pack -c Debug -o out --include-source --version-suffix

@cschuchardt88
Copy link
Member Author

@shargon
image

@cschuchardt88
Copy link
Member Author

Oh you know what it is, the Directory.Build.props isn't being used. I think its a bug with, cause it should be using parent directory. Ill fix, had problem with this on neo-express

Jim8y added a commit to Jim8y/neo that referenced this pull request Dec 31, 2023
@Jim8y
Merge branch 'master' into parallel-transaction-execution
f8f9ef2 
* master: (30 commits)
  Set project as nullable (neo-project#3042)
  Fix: fix equal (neo-project#3028)
  Added README to packages (neo-project#3026)
  Nuget MyGet Fix (neo-project#3031)
  Add: print out the stack (neo-project#3033)
  fixed myget (neo-project#3029)
  Fixed MyGet Workflow (neo-project#3027)
  Package icons - hotfix (neo-project#3022)
  Nuget Package Icon & Symbols (neo-project#3020)
  Fix warning (neo-project#3021)
  Neo-node Migration (neo-project#2990)
  Remove unnecessary default seedlist (neo-project#2980)
  Fix Neo VM target frameworks (neo-project#2989)
  Update Neo.VM location in README.md (neo-project#2988)
  Migrating Neo VM (neo-project#2970)
  3.6.2 (neo-project#2962)
  fix ut (neo-project#2959)
  Validate serialization during Contract deploy and Update (neo-project#2948)
  code optimization (neo-project#2958)
  check null scriptcontainer (neo-project#2953)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cschuchardt88 @shargon