Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added README to packages #3026

Merged
merged 3 commits into from
Dec 30, 2023
Merged

Conversation

cschuchardt88
Copy link
Member

This gets rid of the warning when packing nuget packages, and helps users on nuget as well. So they know what the package is and does.

Change Log

  • Added README.md
  • Updated Directory.Build.props

Removes

The package Neo.3.6.2-CI01441 is missing a readme. Go to https://aka.ms/nuget/authoring-best-practices/readme to learn why package readmes are important.

@cschuchardt88
Copy link
Member Author

@superboyiii @shargon This is a simple fix, please have a look.

Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently nuget didn't work, so first we need to fix that

src/README.md Show resolved Hide resolved
@shargon
Copy link
Member

shargon commented Dec 15, 2023

Blocked by #3024

@cschuchardt88
Copy link
Member Author

Blocked by #3024

Not merging isn't going to fix myget. So development and merging is stopped? We don't even need myget. Its mono-repo now, should be no reason to use it.

@shargon shargon merged commit 9db894f into neo-project:master Dec 30, 2023
2 checks passed
@cschuchardt88 cschuchardt88 deleted the add-readme branch December 30, 2023 12:43
Jim8y added a commit to Jim8y/neo that referenced this pull request Dec 31, 2023
* master: (30 commits)
  Set project as nullable (neo-project#3042)
  Fix: fix equal (neo-project#3028)
  Added README to packages (neo-project#3026)
  Nuget MyGet Fix (neo-project#3031)
  Add: print out the stack (neo-project#3033)
  fixed myget (neo-project#3029)
  Fixed MyGet Workflow (neo-project#3027)
  Package icons - hotfix (neo-project#3022)
  Nuget Package Icon & Symbols (neo-project#3020)
  Fix warning (neo-project#3021)
  Neo-node Migration (neo-project#2990)
  Remove unnecessary default seedlist (neo-project#2980)
  Fix Neo VM target frameworks (neo-project#2989)
  Update Neo.VM location in README.md (neo-project#2988)
  Migrating Neo VM (neo-project#2970)
  3.6.2 (neo-project#2962)
  fix ut (neo-project#2959)
  Validate serialization during Contract deploy and Update (neo-project#2948)
  code optimization (neo-project#2958)
  check null scriptcontainer (neo-project#2953)
  ...
@roman-khimov roman-khimov added this to the v3.7.0 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants