Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[**Fixed**] NuGet Release #3338

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Jun 15, 2024

Change Log

  • Added nuget.yml file
  • Changed and updated files needed for release
  • Added trigger on published release

Closes #3227

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Locally - github workflow

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cschuchardt88 cschuchardt88 mentioned this pull request Jun 15, 2024
14 tasks
@shargon shargon changed the title [**Fixed**|**Updated**] NuGet Release [**Fixed**] NuGet Release Jun 16, 2024
@@ -3,9 +3,9 @@

<PropertyGroup>
<Copyright>2015-2024 The Neo Project</Copyright>
<VersionPrefix>3.7.4</VersionPrefix>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github action step adds it; a-way of making sure you override or forgot to change.

-p:VersionPrefix=${{ env.APP_VERSION }} # Set the version prefix from tag_name

@NGDAdmin NGDAdmin merged commit 90468e8 into neo-project:master Jun 19, 2024
7 checks passed
@cschuchardt88 cschuchardt88 deleted the github/nuget-release branch June 24, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to add nuget packages for neo-modules
4 participants