Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Tests with CI / ACTION to ensure local build is working #3319

Open
vncoelho opened this issue Jun 11, 2024 · 4 comments
Open

Create Tests with CI / ACTION to ensure local build is working #3319

vncoelho opened this issue Jun 11, 2024 · 4 comments

Comments

@vncoelho
Copy link
Member

Related to #3305

Related to #3318 but with local development

Although there were tests with expect, they tests paths related to github action and its workflow.

Recently problems shown that there can be difference between CI and local development.

Thus, devcontainer is a good way to ensure local development will be working as expect, or a generic dockerfile.

@cschuchardt88
Copy link
Member

How does this account for different Operating Systems environment? I been building the pipeline with PRs #3338 #3308 #3306 #3320 #3292, most the problem we ran into were request changes by others, I guess I need to be more firm on this; when it comes to my original chooses.

@vncoelho
Copy link
Member Author

vncoelho commented Jun 18, 2024

https://github.com/neo-project/neo/pull/3338/files and #3308 have nothing related, they are focused on release not testing.

@vncoelho
Copy link
Member Author

The other PRs you mentioned were already merged and they try to fix a problem, not testing.

@cschuchardt88
Copy link
Member

https://github.com/neo-project/neo/pull/3338/files and #3308 have nothing related, they are focused on release not testing.

Thought you meant building & testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants