[Neo Plugin Store] Unit test #3399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cschuchardt88
changed the title
cschuchardt88
previously approved these changes
Jul 5, 2024
…ests * 'snapshot-tests' of github.com:Jim8y/neo: Fix crash when comparing ContractPermissionDescriptor (neo-project#3396) `DeprecatedIn` for events (neo-project#3362) Fix download tips (neo-project#3395)
| snapshot.Commit(); | ||
| CollectionAssert.AreEqual(testValue, store.TryGet(testKey)); | ||
|
|
||
| // Data saved to the leveldb from snapshot1 shall also be visible to snapshot2 |
There was a problem hiding this comment.
Can you check to see if snapshot2 is visible to snapshot1
shargon
reviewed
Jul 5, 2024
|
@cschuchardt88 @shargon updated the tests and reverted the snapshot change, please review again. Snapshot state is immutable, later change to the store will not affect the snapshot, its correct. |
cschuchardt88
previously approved these changes
Jul 6, 2024
shargon
reviewed
Jul 6, 2024
Closed
14 tasks
shargon
approved these changes
Jul 8, 2024
AnnaShaleva
approved these changes
Jul 10, 2024
Jim8y
added a commit
to Jim8y/neo
that referenced
this pull request
Jul 12, 2024
* master: Fixed Publish Step (neo-project#3411) Fix release compilation (neo-project#3417) [Neo Plugin UT] Rpcserver unit test on node (neo-project#3353) Improve code coverage (neo-project#3354) `[Add]` Debug Output to `Expect` (neo-project#3407) [Neo Plugin Store] Unit test (neo-project#3399) Bump System.Text.Json from 8.0.3 to 8.0.4 in /src/Neo.Json (neo-project#3416) # Conflicts: # tests/Neo.Plugins.RpcServer.Tests/TestBlockchain.cs # tests/Neo.UnitTests/Network/P2P/Payloads/UT_Header.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is for testing the snapshot of stores
Fixes # (issue)
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: