Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Add] Debug Output to Expect #3407

Merged
merged 5 commits into from
Jul 11, 2024
Merged

[Add] Debug Output to Expect #3407

merged 5 commits into from
Jul 11, 2024

Conversation

cschuchardt88
Copy link
Member

Description

I don't why this wasn't before. Now setup for locally development use and output detailed information.

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Locally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@NGDAdmin NGDAdmin merged commit 97e24ed into neo-project:master Jul 11, 2024
6 of 7 checks passed
Jim8y added a commit to Jim8y/neo that referenced this pull request Jul 12, 2024
@Jim8y
Merge branch 'master' into snapshot-name
9b79193 
* master:
  Fixed Publish Step (neo-project#3411)
  Fix release compilation (neo-project#3417)
  [Neo Plugin UT] Rpcserver unit test on node (neo-project#3353)
  Improve code coverage (neo-project#3354)
  `[Add]` Debug Output to `Expect` (neo-project#3407)
  [Neo Plugin Store] Unit test (neo-project#3399)
  Bump System.Text.Json from 8.0.3 to 8.0.4 in /src/Neo.Json (neo-project#3416)

# Conflicts:
#	tests/Neo.Plugins.RpcServer.Tests/TestBlockchain.cs
#	tests/Neo.UnitTests/Network/P2P/Payloads/UT_Header.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@Jim8y Jim8y Jim8y approved these changes

@vncoelho vncoelho Awaiting requested review from vncoelho

Assignees
No one assigned
Labels
GitHub Workflow Minor Change ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cschuchardt88 @shargon @Jim8y @NGDAdmin