-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.10.1 #667
Conversation
@@ -115,7 +115,8 @@ internal static bool VerifyWitnesses(this IVerifiable verifiable, Snapshot snaps | |||
{ | |||
engine.LoadScript(verification); | |||
engine.LoadScript(verifiable.Witnesses[i].InvocationScript); | |||
if (!engine.Execute()) return false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could preserve the boolean return
We have a similar problem with travis in other pull request. |
There is no problem with travis. We are using daily build of dependency. That's why these PR are drafts. They should not be merged before change to stable dependency. |
Don't forget to include #673 (comment) before release. @erikzhang should I do a PR or will you push this yourself? |
Make a PR please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks well, when is a draft should i approve it?
No description provided.