Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fifoset (2x) #904

Merged
merged 3 commits into from
Jul 9, 2019
Merged

Fix fifoset (2x) #904

merged 3 commits into from
Jul 9, 2019

Conversation

shargon
Copy link
Member

@shargon shargon commented Jul 9, 2019 •
edited
Loading

Before the patch it return null values
Related to #905

@shargon shargon mentioned this pull request Jul 9, 2019
Merged
@shargon shargon requested review from lock9 and igormcoelho July 9, 2019 17:48
@shargon shargon mentioned this pull request Jul 9, 2019
Closed
@shargon shargon merged commit 5ca7e02 into neo-project:master-2.x Jul 9, 2019
@shargon shargon deleted the fix-fifoset-2x branch July 9, 2019 18:00
@shargon shargon added the bug Used to tag confirmed bugs label Jul 9, 2019
@igormcoelho igormcoelho added the critical Issues (bugs) that need to be fixed ASAP label Jul 9, 2019
igormcoelho
igormcoelho reviewed Jul 9, 2019
View reviewed changes
Copy link
Contributor

@igormcoelho igormcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!!

Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
@Celia18305
fix issue neo-project#902 (neo-project#904)
2b4d485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igormcoelho igormcoelho igormcoelho left review comments

@vncoelho vncoelho vncoelho approved these changes

@erikzhang erikzhang Awaiting requested review from erikzhang

@lock9 lock9 Awaiting requested review from lock9

Assignees
No one assigned
Labels
bug Used to tag confirmed bugs critical Issues (bugs) that need to be fixed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shargon @igormcoelho @vncoelho