Fix fifoset (3x) #905

shargon · 2019-07-09T17:44:27Z

Before the patch it return null values

shargon · 2019-07-09T17:47:30Z

We use the known hash for remove task here

But before the patch we get this

After the patch

So know hashes was not working as expected

igormcoelho · 2019-07-09T17:49:33Z

neo.UnitTests/UT_FifoSet.cs

+        public void FifoSetTest()
+        {
+            var a = UInt256.Zero;
+            var b = new UInt256();


UInt256.Zero? Better than new UInt256(), no?

I want the same data, with different objects

Better to use two new UInt256(). Isn't it clearer? Or does it risk being the same object?

Yes, Is the same

igormcoelho

Congratulations master

codecov-io · 2019-07-09T18:33:08Z

Codecov Report

Merging #905 into master will increase coverage by 0.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
+ Coverage   45.03%   45.16%   +0.13%     
==========================================
  Files         178      178              
  Lines       12608    12608              
==========================================
+ Hits         5678     5695      +17     
+ Misses       6930     6913      -17

Impacted Files	Coverage Δ
neo/IO/Caching/FIFOSet.cs	`71.42% <100%> (+48.57%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54e772a...b0da5a6. Read the comment docs.

vncoelho · 2019-07-09T18:33:59Z

@shargon and @igormcoelho, please check this additional tests for fifo size.

vncoelho · 2019-07-09T19:19:40Z

@shargon, there is something strangeeee..

Tests of 5547a8e should had not passed!!

shargon · 2019-07-09T20:49:13Z

@vncoelho it passed now

vncoelho · 2019-07-09T21:06:55Z

@shargon, commit 5547a8e had errors and passed, something is strange.

vncoelho · 2019-07-09T23:48:10Z

@shargon, I mean, this commit was wrong, it should not have passed.

Something weird is happening.

igormcoelho · 2019-07-10T03:30:53Z

Strange, I'll take a look.

shargon · 2019-07-10T04:54:26Z

The test pass locally, please revert the changes, i will review the problem in few hours

vncoelho · 2019-07-10T05:34:35Z

Shargon, the problem was that all tests were passing locally, even the wrong...ajajajjashauahheuah

shargon · 2019-07-10T05:54:42Z

now pass, what is wrong?

vncoelho

@shargon, it is very strange. I do not know why, but travis was confused here and passed a tested that failed.

I double checked everything locally and test are really failing.
Thus, I believe it is all correct.

I added some more couple of lines for ensuring Fifo max size verification.

shargon · 2019-07-10T18:48:27Z

neo.UnitTests/UT_FifoSet.cs

@@ -27,6 +27,28 @@ public void FifoSetTest()
            Assert.IsTrue(set.Add(c));

            CollectionAssert.AreEqual(set.ToArray(), new UInt256[] { a, c });
+
+                        var d = new UInt256(new byte[32] {


indent please

* Fix fifo set * More tests for FIFO size * Fixing indexes * Testing asset of different sets * Testing again * Update UT_FifoSet.cs * Update UT_FifoSet.cs * Tests for fifo max size * Fixing indentation

…ct#905 (cschuchardt88) Added icon to applications neo-project#908 (cschuchardt88)

Added blockchain show block/transactions/contracts commands neo-project#905 (csc…

* Neo Node Migration * Added blockchain show block/transactions/contracts commands #905 (cschuchardt88) Added icon to applications #908 (cschuchardt88) * Update README.md

Fix fifo set

aa7d602

shargon requested review from erikzhang and vncoelho July 9, 2019 17:44

shargon mentioned this pull request Jul 9, 2019

Fix fifoset (2x) #904

Merged

shargon requested review from igormcoelho, lock9 and jsolman July 9, 2019 17:48

igormcoelho reviewed Jul 9, 2019

View reviewed changes

igormcoelho previously approved these changes Jul 9, 2019

View reviewed changes

vncoelho previously approved these changes Jul 9, 2019

View reviewed changes

igormcoelho added Bug Used to tag confirmed bugs Critical Issues (bugs) that need to be fixed ASAP labels Jul 9, 2019

More tests for FIFO size

5547a8e

vncoelho dismissed stale reviews from igormcoelho and themself via 5547a8e July 9, 2019 18:33

Fixing indexes

3572c9e

shargon requested review from igormcoelho and vncoelho July 9, 2019 20:48

vncoelho added 2 commits July 9, 2019 19:37

Testing asset of different sets

933f09a

Testing again

e62d78e

Update UT_FifoSet.cs

4a239e0

Update UT_FifoSet.cs

0ac840c

erikzhang previously approved these changes Jul 10, 2019

View reviewed changes

vncoelho mentioned this pull request Jul 10, 2019

Speed up multisig ut #908

Merged

Tests for fifo max size

f2b516f

vncoelho dismissed erikzhang’s stale review via f2b516f July 10, 2019 17:11

vncoelho previously approved these changes Jul 10, 2019

View reviewed changes

Fixing indentation

b0da5a6

vncoelho dismissed their stale review via b0da5a6 July 10, 2019 18:09

vncoelho approved these changes Jul 10, 2019

View reviewed changes

shargon commented Jul 10, 2019

View reviewed changes

shargon merged commit 1d949c8 into neo-project:master Jul 10, 2019

shargon deleted the fix-fifoset-3x branch July 10, 2019 18:49

Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020

fix issues (neo-project#905)

59c1fb3

lock9 added a commit to linkd-academy/neo that referenced this pull request Dec 5, 2023

Added blockchain show block/transactions/contracts commands neo-proje…

3b9d542

…ct#905 (cschuchardt88) Added icon to applications neo-project#908 (cschuchardt88)

lock9 added a commit to linkd-academy/neo that referenced this pull request Dec 5, 2023

Added blockchain show block/transactions/contracts commands neo-proje…

cdf2ed3

…ct#905 (cschuchardt88) Added icon to applications neo-project#908 (cschuchardt88)

lock9 added a commit to linkd-academy/neo that referenced this pull request Dec 5, 2023

Added blockchain show block/transactions/contracts commands neo-proje…

9a94202

…ct#905 (cschuchardt88) Added icon to applications neo-project#908 (cschuchardt88)

lock9 added a commit to linkd-academy/neo that referenced this pull request Dec 5, 2023

Merge pull request #1 from linkd-academy/last-neo-node-update

a21e704

Added blockchain show block/transactions/contracts commands neo-project#905 (csc…

shargon pushed a commit that referenced this pull request Dec 7, 2023

Neo-node Migration (#2990)

40d1086

* Neo Node Migration * Added blockchain show block/transactions/contracts commands #905 (cschuchardt88) Added icon to applications #908 (cschuchardt88) * Update README.md

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix fifoset (3x) #905

Fix fifoset (3x) #905

shargon commented Jul 9, 2019

shargon commented Jul 9, 2019 •

edited

Loading

igormcoelho Jul 9, 2019

shargon Jul 9, 2019

igormcoelho Jul 9, 2019 •

edited

Loading

shargon Jul 9, 2019

igormcoelho left a comment

codecov-io commented Jul 9, 2019 •

edited

Loading

vncoelho commented Jul 9, 2019

vncoelho commented Jul 9, 2019

shargon commented Jul 9, 2019

vncoelho commented Jul 9, 2019

vncoelho commented Jul 9, 2019 •

edited

Loading

igormcoelho commented Jul 10, 2019 •

edited

Loading

shargon commented Jul 10, 2019

vncoelho commented Jul 10, 2019 •

edited

Loading

shargon commented Jul 10, 2019

vncoelho left a comment

shargon Jul 10, 2019

Fix fifoset (3x) #905

Fix fifoset (3x) #905

Conversation

shargon commented Jul 9, 2019

shargon commented Jul 9, 2019 • edited Loading

igormcoelho Jul 9, 2019

Choose a reason for hiding this comment

shargon Jul 9, 2019

Choose a reason for hiding this comment

igormcoelho Jul 9, 2019 • edited Loading

Choose a reason for hiding this comment

shargon Jul 9, 2019

Choose a reason for hiding this comment

igormcoelho left a comment

Choose a reason for hiding this comment

codecov-io commented Jul 9, 2019 • edited Loading

Codecov Report

vncoelho commented Jul 9, 2019

vncoelho commented Jul 9, 2019

shargon commented Jul 9, 2019

vncoelho commented Jul 9, 2019

vncoelho commented Jul 9, 2019 • edited Loading

igormcoelho commented Jul 10, 2019 • edited Loading

shargon commented Jul 10, 2019

vncoelho commented Jul 10, 2019 • edited Loading

shargon commented Jul 10, 2019

vncoelho left a comment

Choose a reason for hiding this comment

shargon Jul 10, 2019

Choose a reason for hiding this comment

shargon commented Jul 9, 2019 •

edited

Loading

igormcoelho Jul 9, 2019 •

edited

Loading

codecov-io commented Jul 9, 2019 •

edited

Loading

vncoelho commented Jul 9, 2019 •

edited

Loading

igormcoelho commented Jul 10, 2019 •

edited

Loading

vncoelho commented Jul 10, 2019 •

edited

Loading