Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classes for PublicKey and Signature #990

Closed
wants to merge 4 commits into from

Conversation

igormcoelho
Copy link
Contributor

Closes #989

@codecov-io
Copy link

codecov-io commented Aug 3, 2019

Codecov Report

Merging #990 into master will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #990      +/-   ##
=========================================
+ Coverage   53.77%   53.8%   +0.03%     
=========================================
  Files         194     196       +2     
  Lines       13251   13290      +39     
=========================================
+ Hits         7126    7151      +25     
- Misses       6125    6139      +14
Impacted Files Coverage Δ
neo/Cryptography/PublicKey.cs 0% <0%> (ø)
neo/Cryptography/Signature.cs 0% <0%> (ø)
neo/Ledger/StorageKey.cs 64.1% <0%> (-1.12%) ⬇️
neo/SmartContract/InteropService.NEO.cs 26.74% <0%> (+1%) ⬆️
neo/IO/Caching/Cache.cs 100% <0%> (+1.87%) ⬆️
neo/SmartContract/Native/Tokens/NeoToken.cs 53.21% <0%> (+5.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53f7d02...472d161. Read the comment docs.

Copy link
Contributor

@lock9 lock9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are these classes being used? Shouldn't we have some tests too?

@igormcoelho
Copy link
Contributor Author

Still under discussiin @lock9

@shargon
Copy link
Member

shargon commented Aug 7, 2019

Is ok to me

@erikzhang
Copy link
Member

Can we close this PR? I think it is a big project to completely replace all public keys and signatures.

@igormcoelho igormcoelho closed this Aug 8, 2019
@igormcoelho igormcoelho deleted the crypto_pubkey_sig branch August 8, 2019 14:47
@igormcoelho
Copy link
Contributor Author

Ok, the idea remains, for the future. I think it's very important for readability.

Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create class for PublicKey and Signature
5 participants