Apply trivial fixes to NEP-1 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
approved these changes
Nov 8, 2019
vncoelho
reviewed
Nov 8, 2019
| @@ -33,13 +33,13 @@ The NEP process begins with a new idea for NEO. It is highly recommended that a | |||
|
|
|||
| Each NEP must have a champion - someone who writes the NEP using the style and format described below, shepherds the discussions in the appropriate forums, and attempts to build community consensus around the idea. | |||
|
|
|||
| Vetting an idea publicly before going as far as writing an NEP is meant to save the potential author time. Asking the NEO community first if an idea is original helps prevent too much time being spent on something that is guaranteed to be rejected based on prior discussions (searching the Internet does not always do the trick). It also helps to make sure the idea is applicable to the entire community and not just the author. Just because an idea sounds good to the author does not mean it will work for most people in most areas where NEO is used. Examples of appropriate public forums to gauge interest around your NEP include [https://www.reddit.com/r/NEO the NEO subreddit], [https://github.com/neo-project/proposals/issues the Issues section of this repository], and [http://slack.neo.org one of the NEO Slack channels]. In particular, [https://github.com/neo-project/proposals/issues the Issues section of this repository] is an excellent place to discuss your proposal with the community and start creating more formalized language around your NEP. | |||
| Vetting an idea publicly before going as far as writing an NEP is meant to save the potential author time. Asking the NEO community first if an idea is original helps prevent too much time being spent on something that is guaranteed to be rejected based on prior discussions (searching the Internet does not always do the trick). It also helps to make sure the idea is applicable to the entire community and not just the author. Just because an idea sounds good to the author does not mean it will work for most people in most areas where NEO is used. Examples of appropriate public forums to gauge interest around your NEP include [https://www.reddit.com/r/NEO the NEO subreddit], [https://github.com/neo-project/proposals/issues the Issues section of this repository], and [https://discord.io/neo the NEO Discord]. In particular, [https://github.com/neo-project/proposals/issues the Issues section of this repository] is an excellent place to discuss your proposal with the community and start creating more formalized language around your NEP. | |||
There was a problem hiding this comment.
@corollari, this part is looks wrong:
" [https://github.com/neo-project/proposals/issues the Issues section of this repository]"
Perhaps the link needs a ] before
There was a problem hiding this comment.
I just double checked and it should be alright, maybe the confusion stems from the fact that these are mediawiki-style links instead of markdown-style ones?
erikzhang
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing important, just replacing the outdated slack workspace for the current discord server and a minor typo fix.