Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authors name addition on NEP 17 #127

Closed
wants to merge 4 commits into from
Closed

Conversation

vncoelho
Copy link
Member

@vncoelho vncoelho commented Nov 12, 2020

@erikzhang contributed with organization, revisions on original idea and proposal analysis.
@shargon contributed with experimentation, testing and analysis.
@igormcoelho contributed with revisions on the original idea and proposal analysis.
@belane contributed with the original idea regarding the adjustment of onPayment.
@roman-khimov contributed with revisions, experimentation and testing (neo-go).
@vncoelho contributed with revisions on the original idea and verification.

nep-17.mediawiki Outdated Show resolved Hide resolved
@erikzhang
Copy link
Member

When nominating the author’s name, please describe his contribution to the proposal.

@vncoelho vncoelho changed the title Author name addition on NEP 17 Authors name addition on NEP 17 Nov 13, 2020
@vncoelho
Copy link
Member Author

vncoelho commented Nov 13, 2020

@erikzhang, I am adding the description in the PR.

@igormcoelho @shargon @belane @roman-khimov, I added you to this PR and a brief description.
Fell free to update the PR.

Names have been added in alphabetic order.

@roman-khimov, I added your role as testing as well because I believe that soon as accepted you are also going to provide an example using the neo-go.

@vncoelho
Copy link
Member Author

@erikzhang, ping @lllwvlvwlll and other previous authors of NEP-5 in order to invite them to join as co-authors as well.
Part of the text is still from NEP-5, as well as some logic behind.

@@ -1,7 +1,7 @@
<pre>
NEP: 17
Title: Token Standard
Author: Erik Zhang <erik@neo.org>
Author: Erik Zhang <erik@neo.org>, Fernando Díaz Toledano <shargon@gmail.com>, Igor Machado Coelho <igor.machado@gmail.com>, Jaime Kindelan <jaime@red4sec.com>, Roman Khimov <roman@nspcc.ru>, Vitor Nazário Coelho <vncoelho@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Author: Erik Zhang <erik@neo.org>, Fernando Díaz Toledano <shargon@gmail.com>, Igor Machado Coelho <igor.machado@gmail.com>, Jaime Kindelan <jaime@red4sec.com>, Roman Khimov <roman@nspcc.ru>, Vitor Nazário Coelho <vncoelho@gmail.com>
Author: Erik Zhang <erik@neo.org>, Igor Machado Coelho <igor.machado@gmail.com>, Jaime Kindelan <jaime@red4sec.com>, Roman Khimov <roman@nspcc.ru>, Vitor Nazário Coelho <vncoelho@gmail.com>

I doesn't feel like an author

Copy link
Member Author

@vncoelho vncoelho Nov 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok,Shargon, I believe yes, you are contributing to make this standard solid.

Copy link
Member Author

@vncoelho vncoelho Nov 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are not going to include yourself I will also close this issue because the list will become quite strict.

We also need to check with previous nep5 authors.

@vncoelho vncoelho closed this Nov 14, 2020
@vncoelho vncoelho deleted the patch-4 branch November 16, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants