Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process crash #39

Closed
jane567 opened this issue Apr 28, 2016 · 4 comments
Closed

Process crash #39

jane567 opened this issue Apr 28, 2016 · 4 comments

Comments

@jane567
Copy link
Contributor

jane567 commented Apr 28, 2016 •
edited
Loading

Hi!
I found that process (python loki.py or loki.exe) crashed when processing yara rules and found cyrillic filename. Crash occured in proc scan_path at line
# Scan the read data for (score, rule, description, matched_strings) in \ self.scan_data(fileData, fileType, filename, filePath, extension, md5):
Can you fix this issue?
Thanks.
@Neo23x0
Copy link
Owner

Neo23x0 commented Apr 30, 2016

Cannot reproduce, tried to fix this in 0.15.3

@Neo23x0 Neo23x0 closed this as completed Apr 30, 2016
@jane567
Copy link
Contributor Author

jane567 commented Apr 30, 2016

I'm so sorry!
I forgot to say that in original script (loki.py) this error can't occur at all. It seems you just skip processing filenames in unicode. So I was forced to change your code a little to accomplish processing filenames in russian. See attached diff
loki.diff.txt

@jane567 jane567 mentioned this issue Apr 30, 2016
Closed
@Neo23x0
Copy link
Owner

Neo23x0 commented Apr 30, 2016

Great, thanks.
Could you generate a pull request on the loki.py, so that I can just accept it after testing?
Just click "Edit" on the "thor.py" file, then copy & paste the changed source code and then select "creat pull request".

@Neo23x0 Neo23x0 reopened this Apr 30, 2016
jane567 added a commit to jane567/Loki that referenced this issue Apr 30, 2016
@jane567
unicode support
0660bdc 
in Neo23x0#39 etc
@jane567 jane567 mentioned this issue Apr 30, 2016
Merged
@jane567
Copy link
Contributor Author

jane567 commented Apr 30, 2016

I hope all done correct ..

@Neo23x0 Neo23x0 closed this as completed Apr 30, 2016
MeteorAdminz pushed a commit to MeteorAdminz/Loki that referenced this issue Dec 15, 2016
@jane567
unicode support
5c0a180 
in Neo23x0#39 etc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Neo23x0 @jane567