Fixes #1630: apoc.load.csv doesn't support basic auth #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vga91
added a commit
to vga91/neo4j-apoc-procedures
that referenced
this pull request
Dec 10, 2020
…eo4j-contrib#1726) * fixes neo4j-contrib#1630: apoc.load.csv doesn't support basic auth * code clean * code clean * changed tests * changed tests LoadJson - LoadCsv
conker84
pushed a commit
to conker84/neo4j-apoc-procedures
that referenced
this pull request
Mar 23, 2021
…eo4j-contrib#1726) * fixes neo4j-contrib#1630: apoc.load.csv doesn't support basic auth * code clean * code clean * changed tests * changed tests LoadJson - LoadCsv
fbiville
pushed a commit
that referenced
this pull request
Mar 25, 2021
conker84
pushed a commit
to conker84/neo4j-apoc-procedures
that referenced
this pull request
Mar 29, 2021
…eo4j-contrib#1726) * fixes neo4j-contrib#1630: apoc.load.csv doesn't support basic auth * code clean * code clean * changed tests * changed tests LoadJson - LoadCsv
conker84
pushed a commit
that referenced
this pull request
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1630
To make the procedure behavior consistent with the other loaders,
I added the
apoc.load.csvParamsprocedure,useful if I want to load a csv on a server that requires a header and / or a payload,
in the same way as
apoc.load.jsonParams.One sentence summary of the change.
Proposed Changes (Mandatory)
A brief list of proposed changes in order to fix the issue:
http://user:password@hostapoc.load.csvParamssimilarly toapoc.load.jsonParamsprocedureLoadCsvTest.javato cover cases of the related issueextractCredentialsIfNeeded(url, failOnError)common method fromLoadJson.javatoUtil.javaLoadJsonTest.javato cover same cases of the issuereaderFor(String fileName, Map<String, Object> headers, String payload)method inFileUtils.java