Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BqvAC2FK] Update selenium dependencies #3663

Merged
merged 4 commits into from
Aug 30, 2023
Merged

[BqvAC2FK] Update selenium dependencies #3663

merged 4 commits into from
Aug 30, 2023

Conversation

vga91
Copy link
Collaborator

@vga91 vga91 commented Jul 17, 2023

Waiting for CI error fixes: #3666


The selenium version can be updated as it was previously blocked due to the guava version: #2013 .

Now that problem is not present anymore.


  • Update to the latest selenium

    • Update to the latest webdrivermanager package
    • Removed 0.30.0 version, not compatible with the new firefox webdriver version
    • Changed error message on line 99
    • new WebDriverWait(...)
    • changed .setHeadless(isHeadless); which are deprecated and throw an error NoSuchMethodError: '...irefoxOptions.setHeadless(boolean)
    • excluded guava from webdrivermanager plugin, otherwise a java.lang.NoSuchMethodError: 'void com.google.common.base.Throwables.throwIfUnchecked is thrown
  • Other changes

    • Added browser start-up failure to ignored error, in order to skip if browser version on the running machine is not compatible with the latest webdriver
    • Improved "wrong config" error message, previously was a generic "Invalid config: LoadHtmlConfig@123123"
    • De-mocked list of browser config in LoadHtmlTestParameterized.java

@vga91 vga91 changed the title Update selenium deps [BqvAC2FK] Update selenium dependencies Jul 21, 2023
@conker84 conker84 merged commit c9c4fcb into dev Aug 30, 2023
7 checks passed
@conker84 conker84 deleted the update-selenium-deps branch August 30, 2023 09:33
vga91 added a commit that referenced this pull request Aug 30, 2023
* [BqvAC2FK] Update selenium dependencies

* [BqvAC2FK] solve deps conflicts

* [BqvAC2FK] removed ext. dep

* [BqvAC2FK] add testImplementation dep.
vga91 added a commit that referenced this pull request Aug 30, 2023
* [BqvAC2FK] Update selenium dependencies

* [BqvAC2FK] solve deps conflicts

* [BqvAC2FK] removed ext. dep

* [BqvAC2FK] add testImplementation dep.
vga91 added a commit that referenced this pull request Aug 30, 2023
* [BqvAC2FK] Update selenium dependencies

* [BqvAC2FK] solve deps conflicts

* [BqvAC2FK] removed ext. dep

* [BqvAC2FK] add testImplementation dep.
vga91 added a commit that referenced this pull request Aug 31, 2023
* [BqvAC2FK] Update selenium dependencies

* [BqvAC2FK] solve deps conflicts

* [BqvAC2FK] removed ext. dep

* [BqvAC2FK] add testImplementation dep.
recrwplay pushed a commit to recrwplay/neo4j-apoc-procedures that referenced this pull request Aug 31, 2023
* [BqvAC2FK] Update selenium dependencies

* [BqvAC2FK] solve deps conflicts

* [BqvAC2FK] removed ext. dep

* [BqvAC2FK] add testImplementation dep.
vga91 added a commit that referenced this pull request Oct 23, 2023
* [BqvAC2FK] Update selenium dependencies

* [BqvAC2FK] solve deps conflicts

* [BqvAC2FK] removed ext. dep

* [BqvAC2FK] add testImplementation dep.
vga91 added a commit that referenced this pull request Dec 22, 2023
* [BqvAC2FK] Update selenium dependencies

* [BqvAC2FK] solve deps conflicts

* [BqvAC2FK] removed ext. dep

* [BqvAC2FK] add testImplementation dep.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants