Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

podAnnnotations with Boolean in Map do not work #65

Closed
mohammadsrahman opened this issue Jul 30, 2020 · 4 comments
Closed

podAnnnotations with Boolean in Map do not work #65

mohammadsrahman opened this issue Jul 30, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@mohammadsrahman
Copy link
Contributor

I am trying to add in an annotation as follows:

neo4j:
    podAnnotations:
        - sidecar.istio.io/inject: "false"

But the Go templates are complaining the formatting is incorrect.

See line below for contributing failure.

neo4j-helm/values.yaml

Line 34 in cce71f3

podAnnotations: {}

@moxious
Copy link
Contributor

moxious commented Aug 7, 2020

This issue is caused by improper inclusion of the values in the resulting YAML template. Working on a fix right now.

moxious added a commit that referenced this issue Aug 7, 2020
@moxious
fixes issue #65 improper inclusion of custom labels/annotations
24cc295
@moxious
Copy link
Contributor

moxious commented Aug 7, 2020

Related PR: #73

@moxious
Copy link
Contributor

moxious commented Aug 7, 2020

A different issue is that the top level "neo4j" key isn't needed, and the podAnnotations should be expressed as a MAP not as an array item as is given in this ticket.

See the deployment-scenarios/cluster-custom-labels-annotations.yaml example that is in the PR as an example of how to set custom labels & annotations correctly in a way that works.

@moxious moxious added the bug Something isn't working label Aug 7, 2020
moxious pushed a commit that referenced this issue Aug 7, 2020
Issue 65 pod annotations (#73)
60c2aab 
* fixes issue #65 improper inclusion of custom labels/annotations

* switch CI system to use deployment examples; prove custom annotations/labels

* example deployment scenario custom labels/annotations
@moxious
Copy link
Contributor

moxious commented Aug 7, 2020

Closed by PR referenced above.

@moxious moxious closed this as completed Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mohammadsrahman @moxious