Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Issue 65 pod annotations #73

Merged
merged 5 commits into from
Aug 7, 2020
Merged

Issue 65 pod annotations #73

merged 5 commits into from
Aug 7, 2020

Conversation

moxious
Copy link
Contributor

@moxious moxious commented Aug 7, 2020

  • Because of the key/value inclusion technique for custom labels/annotations, quotation marks were getting stripped, leading to errors with some data types. Simple toYaml inclusion doesn't work due to different templating errors, so this fix makes it possible to include any string values.
  • Added deployment examples on custom annotations/labels, but also switched the CI system to deploy the test cases from deployment examples, rather than via --set on the helm CLI

@moxious moxious merged commit 60c2aab into master Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant